Closed merrielle closed 2 years ago
The code looks good and the test is great. The only thing we need to figure out before merging this is to finalize the directory of the code in the repo and the files in the blob storage. For the convenience of further discussion, here is what we have (comments in brackets open for discussion):
prereise/utility/generate_rural_shapefiles.py
(probably we want this module sitting closely with transportation module)prereise/utility/shapefile.py
(this provides a general interface of downloading shapefiles from blob storage and makes perfect sense to be part of utility module)https://besciences.blob.core.windows.net/us-shapefiles/
https://besciences.blob.core.windows.net/shapefiles/urban-area-shapefiles/
(We probably want to reorganize all shapefiles currently on the blob storage as discussed during the meeting)
Pull Request doc
Purpose
Addresses https://github.com/Breakthrough-Energy/PreREISE/issues/273 Adds function to create shapefiles for urban areas and rural areas for each state
What the code is doing
Testing
TBD
Where to look
It's helpful to clarify where your new code lives if you moved files around or there could be confusion/
What files are most important?
Usage Example/Visuals
How the code can be used and/or images of any graphs, tables or other visuals (not always applicable).
Time estimate
10 mins