search

BrianHepler / MMM-WeatherBackground

MagicMirror Module - for Weather image background from Unsplash. This is a plugin of other weather modules.
MIT License
16 stars 9 forks source link

MMM-NOAA3 - Dont get the sunset time from the payload #19

Closed salvega90 closed 1 year ago

BrianHepler commented 1 year ago

You're disabling the feature whereby it changes the background image from a day-themed image to an nighttime image. This will display a daytime image all day long. Which is better than not displaying an image. Let me see about putting in some fallback logic.

BrianHepler commented 1 year ago

In addition to you correctly locating the bug, I found another bug while I was adding some logic to detect if the sunset value wasn't provided. It turns out that the original code used getDay() to extract the date which only returns the day of the week. getDate() will give you the day of the month. So for most of the month, the module thought it was nighttime. Weird.

I'm going to merge your PR and then merge my changes on top of it so you get credit for contributing. Thanks for doing the work.