search

BrianHepler / MMM-WeatherBackground

MagicMirror Module - for Weather image background from Unsplash. This is a plugin of other weather modules.
MIT License
16 stars 9 forks source link

pull request 2023 #23

Closed mirrormonark closed 1 year ago

mirrormonark commented 1 year ago

hi, please add ability to enable video and sound

BrianHepler commented 1 year ago

Hi. No, I'm not going to do this. For a few reasons:

  1. The website the module uses to pull the images only hosts images.
  2. At present, the latest version of Raspian only includes VLC which is unsuitable for playing embedded video.
  3. I have no idea how to resolve the conflict between a local sound file and the audio track on a video file.
  4. I have no idea where to pull appropriate videos related to the current weather being broadcast by other modules.
  5. I have no idea how to remove the advertisements from common free video websites.

All that said, if you can figure out how to enable such a feature and create a pull request, I will happily review it for consideration. Let me know if you have questions on how this module works.

mirrormonark commented 1 year ago

I am not very familiar with programming. my idea was to have the videos locally (with sound or without sound) and associate them with the weather.. exactly like it is done with photos or taking cues from weather modules (weather icons). a downloaded video or gif does not contain advertisements. but i trust on what you say, if then there is the problem with vlc then i don't know if something can be done. my example was

"rain"="rain.mp4" (maybe a video of city rain or mountain rain) "snow"="snow.mp4" (maybe a video of snow coming down from the sky/over the mirror or a burning fireplace)

i think you would probably have to recreate it even with the images so that it just takes it locally and not from websites. it would be nice for me to do that, but I'm afraid of destroying something. thank you for asnwer me.