BruceJohnJennerLawso / scrap

Hockey stats analysis done by scraping the data to a csv file, then processing/analyzing them with more python.
3 stars 0 forks source link

More issues with graph axes bounds #110

Closed BruceJohnJennerLawso closed 7 years ago

BruceJohnJennerLawso commented 7 years ago

Current example is

python teamStatGraph.py nhl postLockout False Defence ADQI

For some weird reason it is putting +9.99 at the bottom right corner and the axes range is really tiny, at 0.000 - 0.020

adqi_by_defence

BruceJohnJennerLawso commented 7 years ago

looks like a flaw in the axes setting code, its setting the same y min & max

BruceJohnJennerLawso commented 7 years ago

traced the issue to the getGraphBounds function in graphtools. Looks like whenever the min & maxes of the dataset are within the value of snapToNearest of each other, the bounds get set as the same number

BruceJohnJennerLawso commented 7 years ago

fixed it by having the function sanity check its results and adjust if it fucked up. Done as of fcfaf40e8428416ca1850ecaeae415b47d0e9500