search

BruceJohnJennerLawso / scrap

Hockey stats analysis done by scraping the data to a csv file, then processing/analyzing them with more python.
3 stars 0 forks source link

Migration to game spread object containers #67

Closed BruceJohnJennerLawso closed 7 years ago

BruceJohnJennerLawso commented 7 years ago

The system currently has team stats set up as being called for the team that they refer to, totalled & averaged for an entire season. This is a working system for the moment, but I want to be able to do (at some point) things like selecting the front and back halves of a season, the first 10 games, etc., like

team.seasonGames(firstHalf).getCPQI()

The unfortunate thing is that this will require a potentially massive codebase rewrite to make happen, given how many places a teams stats are called directly. So... I better get cracking on this.

BruceJohnJennerLawso commented 7 years ago

or better titled, seasonPart(firstHalf)

BruceJohnJennerLawso commented 7 years ago

This is going to make load times even longer cause seasonPart is going to be an object that gets loaded when the team is constructed, and it will cost runtime to tally the results for each segment (totalSeason, firstHalf, secondHalf, etc.)

BruceJohnJennerLawso commented 7 years ago

I think this can be called fully armed and operational as of 9acd0920f6183eae57069d13e315f56726e9b868, although variable season comparisons as described in #74 still needs to be tested

BruceJohnJennerLawso commented 7 years ago

Per #74 closing, this is done on the seasonParts branch

BruceJohnJennerLawso commented 7 years ago

Really, reaallllly done

BruceJohnJennerLawso commented 7 years ago

Aka done like dinner done