BuilderIO / mitosis

Write components once, run everywhere. Compiles to React, Vue, Qwik, Solid, Angular, Svelte, and more.

https://mitosis.builder.io

MIT License

11.86k stars 516 forks source link

fix for issue No #1350 #1368

Closed GhoshAnup closed 2 months ago

GhoshAnup commented 4 months ago

formatting slot name to kebab casing to make it consistent across Angular and Vu js

Description

I have made changes in slots.ts file. I have added a function to format the slot name such a way, so it stays consistent after compilation by Angular or Vu js.
As with current implementation the slots names were not consistent, Anguler js compiling to kebab case where vu js wasn't. Also, as per VU js documentation it's a good practice to name as per kebab casing. So, with this new function we will format the slot name to kebab casing.
I have tried to implement minimum changes to achieve the desired result of maintaining consistency in the slot name across Angular and VU js. So with this new method I am able to fix the issue. I have tested my changes in the provided repro steps.

This sort of information is useful for people reviewing the code, as well as anyone from the future trying to understand why changes were made or why a bug started happening.

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: 4c66669e51c39a4aca6cf4918c76a9ad3954d66c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
mitosis-fiddle	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 18, 2024 1:54am

nx-cloud[bot] commented 4 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4c66669e51c39a4aca6cf4918c76a9ad3954d66c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 4 targets

- [`nx build @builder.io/mitosis-fiddle`](https://cloud.nx.app/runs/LuIWOLaXXw?utm_source=pull-request&utm_medium=comment) - [`nx run-many --skip-nx-cache --target build --parallel 4 --exclude */e2e-alpine,*/e2e-angular,@builder.io/mitosis-fiddle,@builder.io/talk-*,@builder.io/example-apps`](https://cloud.nx.app/runs/u6xS2pXWaO?utm_source=pull-request&utm_medium=comment) - [`nx build @builder.io/eslint-plugin-mitosis`](https://cloud.nx.app/runs/1Im4fqdU9g?utm_source=pull-request&utm_medium=comment) - [`nx build @builder.io/mitosis`](https://cloud.nx.app/runs/EEAu8lInsq?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.