search

BuilderIO / mitosis

Write components once, run everywhere. Compiles to React, Vue, Qwik, Solid, Angular, Svelte, and more.
https://mitosis.builder.io
MIT License
11.84k stars 513 forks source link

fix: remove 2 deprecated dependencies in core package #1385

Closed rqzheng2015 closed 1 day ago

rqzheng2015 commented 3 months ago

Description

Remove 2 deprecated dependencies: vue and @babel/plugin-proposal-class-properties

Why?

Solution

Vue

There are just 1 place in core's code to import vue for its ts definition. So we could copy them and remove the import of vue2

@babel/plugin-proposal-class-properties

As there were 0 places to import @babel/plugin-proposal-class-properties, we could just remove the import of it.

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 22a0ac4ef1d069a00e3aadcff7af54375c72244c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ----------------------- | ----- | | @builder.io/mitosis | Patch | | @builder.io/mitosis-cli | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mitosis-fiddle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 1:40pm
nx-cloud[bot] commented 3 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 22a0ac4ef1d069a00e3aadcff7af54375c72244c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 4 targets - [`nx run-many --target test`](https://cloud.nx.app/runs/qAapXCKmYD?utm_source=pull-request&utm_medium=comment) - [`nx e2e @builder.io/e2e-app`](https://cloud.nx.app/runs/B6thxwoTju?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target build --exclude @builder.io/e2e-alpine`](https://cloud.nx.app/runs/fgVypz1lpJ?utm_source=pull-request&utm_medium=comment) - [`nx build @builder.io/mitosis-site`](https://cloud.nx.app/runs/Anqo5Et3wm?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

rqzheng2015 commented 2 months ago

Hi @samijaber, please check this PR if you are free, thanks.

rqzheng2015 commented 1 week ago

Hi @samijaber, please check this PR when you are free. It reduces some unnecessary dependencies in core package, which might speed up the installation process.

samijaber commented 5 days ago

Thanks for this contribution! 🙏🏽

rqzheng2015 commented 3 days ago

Hi @samijaber , sorry to bother again. But the github checks seems to be waiting for Cloudflare pages to be deployed, how could I run this Cloudlflare check manually? It is now stucking. Please check this when you are free, thanks.

samijaber commented 1 day ago

@rqzheng2015 That check shouldn't be there, it's a mistake. Your PR is good to go and merged!