BuilderIO / mitosis

Write components once, run everywhere. Compiles to React, Vue, Qwik, Solid, Angular, Svelte, and more.
https://mitosis.builder.io
MIT License
12.36k stars 549 forks source link

fix(docs): hide overview ruler column in code editor #1453

Closed sean-perkins closed 4 months ago

sean-perkins commented 4 months ago

Description

The monaco code editor in the playground shows a small gray border where the overview ruler is.

CleanShot 2024-05-23 at 00 10 11@2x

This PR disables that canvas element (border) from rendering:

CleanShot 2024-05-23 at 00 12 23@2x

Documentation for overviewRulerLanes option is available here: https://microsoft.github.io/monaco-editor/docs.html#interfaces/editor.IStandaloneEditorConstructionOptions.html#overviewRulerLanes

I believe this is the intended visual display based on the vertical scrollbars being hidden. I'm not sure why the production site is not capitalizing the dropdown text for "jsx" vs. "Jsx" as seen in the screenshots, but that is outside of the scope of my changes.

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: fe48c5bc043f2d1b9ed5be82dc4c93293680cd0d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud[bot] commented 4 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fe48c5bc043f2d1b9ed5be82dc4c93293680cd0d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets - [`nx run-many --skip-nx-cache --target build --parallel 4 --exclude */e2e-alpine,@builder.io/mitosis-fiddle,@builder.io/talk-*,@builder.io/example-apps`](https://cloud.nx.app/runs/eUuhFYxrIP?utm_source=pull-request&utm_medium=comment) - [`nx build @builder.io/mitosis-site`](https://cloud.nx.app/runs/lS2KjtWaKz?utm_source=pull-request&utm_medium=comment) - [`nx build @builder.io/eslint-plugin-mitosis`](https://cloud.nx.app/runs/860AKHLnlx?utm_source=pull-request&utm_medium=comment) - [`nx build @builder.io/mitosis`](https://cloud.nx.app/runs/kcmnqG1Wy2?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.