Refs are broken on Qwik - Githubissues

BuilderIO / mitosis

Write components once, run everywhere. Compiles to React, Vue, Qwik, Solid, Angular, Svelte, and more.

https://mitosis.builder.io

MIT License

12.54k stars 558 forks source link

Refs are broken on Qwik #940

Open CKGrafico opened 1 year ago

CKGrafico commented 1 year ago

I am interested in helping provide a fix!

No

Which generators are impacted?

[ ] All
[ ] Angular
[ ] HTML
[X] Qwik
[ ] React
[ ] React-Native
[ ] Solid
[ ] Stencil
[ ] Svelte
[ ] Vue
[ ] Web components

Reproduction case

https://mitosis.builder.io/?outputTab=I4dwlg1kA%3D%3D%3D&code=JYWwDg9gTgLgBAbzgVwM4FMDKNroDQoYBK6AZnAL5ylQQhwBEAAgEbLAA2AJulAHTAIAehDAcqYKgYBuAFCz0AD0iw4PUgENkHeKWQA7AMYxB%2BuAFkAngGE6kfen0wAFGFphUASkSy4cQxD6qPDA%2BmDIMCTkALyE6FHOnnK%2B%2FoHBcMEaMOhwsWhYOFDozggpfvoaIOgAXIzY6ABu6Ax4ZXCBAEIcyFCJPn4DcKHhkWR8pBCGaIltFK2DAObo8BwQAO681hoYAHKVxd6lg35FMD1mmdl8FVV8OAAy65vbB3KDFCkUSfLyJ8vncGcbQAPFxgA0AHxtPwINwQDx8VAAC3WAEkwhE4AAyLGA6EDYHDCL4wZFUjRBBE0akD7HY6GVCoClHOn0iCrKC1BhFLgtEkDCi01l%2BBoabroCmXdDXfZC4WdbpQCnORqOGDeaIQjIwLLShU9RJy1mBaxIjT6JbK1VODVapBSmVVXJwa0wO4aKBLN2i8WUI2DIRQumef1wAAS6A4q3xCAdqw2UC2u1lAEI4Kj%2FOa4FADEMzCQNMYCAA1ZD4OCYdnALgEaBwe7AACO7C4KZBQjBkJS3woQA&inputTab=FYZwHkA%3D

Expected Behaviour

work like in #596

Actual Behaviour

not working

Additional Information

No response

samijaber commented 1 year ago

useRef is actually deprecated/non-existant in Qwik. We should be:

generating useSignal
accessing the values using x.value (adding .value suffix)

https://qwik.builder.io/docs/components/state/#usesignal