Closed tsbyq closed 2 years ago
I don't understand. I believe the name does match my repo name...?
On Tue, Sep 21, 2021 at 1:07 PM Katherine Fleming @.***> wrote:
@.**** requested changes on this pull request.
In bcl_manifest.json https://github.com/BuildingComponentLibrary/bcl-manifest/pull/11#discussion_r713380189 :
@@ -55,5 +55,10 @@
"org": "Ski90Moo", "type": "component", "url": "https://github.com/Ski90Moo/OpenStudio_Components_HEPLLC"
},{
"name": "OpenStudio Occupant-related Variability Measures Gem",
⬇️ Suggested change
"name": "OpenStudio Occupant-related Variability Measures Gem",
"name": "OpenStudio-Occupant-Variability-Gem",
In bcl_manifest.json https://github.com/BuildingComponentLibrary/bcl-manifest/pull/11#discussion_r713380405 :
@@ -55,5 +55,10 @@
"org": "Ski90Moo", "type": "component", "url": "https://github.com/Ski90Moo/OpenStudio_Components_HEPLLC"
},{
"name": "OpenStudio Occupant-related Variability Measures Gem",
the name must match your repo name exactly. otherwise it looks good!
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BuildingComponentLibrary/bcl-manifest/pull/11#pullrequestreview-760202514, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQUKBFE7HYLBTDOGLHFFEXTUDDQYLANCNFSM5EO6XYRQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
-- Best Regards, Mike Lovejoy P.E. Helix Energy Partners LLC Helix, OR http://www.helix-engineers.net/ https://deref-mail.com/mail/client/aJLmMsp2k0Y/dereferrer/?redirectUrl=http%3A%2F%2Fwww.helix-engineers.net%2F P:541-379-0271
Sorry @tsbyq, looks like you stepped on some changes...restore the 'openstudio-measure' repo that got deleted when develop was merged back into your branch and then we should be good to go. thanks! https://github.com/BuildingComponentLibrary/bcl-manifest/blob/develop/bcl_manifest.json#L58-L62
@kflemin I restored the 'openstudio-measure' repo that was deleted by mistake.
Adding LBNL's Occupant Variability Measures Gem to the BCL manifest.