BuildingSync / BuildingSync-gem

Other
2 stars 1 forks source link

small/med/large office classification based on incorrect unit #138

Open JanghyunJK opened 2 years ago

JanghyunJK commented 2 years ago

just FYI and nothing posing risk on my end but if I'm looking at this right:

Element ID: 2 started with occupancy_classification Office and total floor area: 929.0304000000001
selected the following standards_building_type: SmallOffice
Element ID: 4 started with occupancy_classification Office and total floor area: 2322.576
selected the following standards_building_type: SmallOffice
haneslinger commented 8 months ago

however BUILDING_AND_SYSTEMS_FILE_PATH is used exclusively by process_bldg_and_system_type, which assumes BUILDING_AND_SYSTEMS_FILE_PATH and the model are in the same units, which is untrue.

It's an easy fix. Just trying to figure out how to write the test