search

BurntSushi / rust-snappy

Snappy compression implemented in Rust (including the Snappy frame format).
BSD 3-Clause "New" or "Revised" License
445 stars 43 forks source link

2018 Edition #25

Closed gsquire closed 4 years ago

gsquire commented 5 years ago

This PR migrates the crate to use the 2018 edition. Although the diff is large, it is mostly from the first commit which used the use_try_shorthand configuration in rustfmt to update the try! calls. After that I slowly ran cargo +nightly fix --edition and committed those changes. The last commit bumps the minor version and adds the edition key to the manifest.

BurntSushi commented 4 years ago

Thanks for doing this! Unfortunately, I want to get #18 merged first, and since merging this first would likely make that unnecessarily difficult, I'm going to close this. I plan to do this myself (along with some other cleanup) soonish.

gsquire commented 4 years ago

Cool, that makes sense to me. Let me know if I can help.