BurntSushi / rust-snappy

Snappy compression implemented in Rust (including the Snappy frame format).
BSD 3-Clause "New" or "Revised" License
445 stars 43 forks source link

look into failing roundtrip tests on macos #46

Open BurntSushi opened 3 years ago

BurntSushi commented 3 years ago

CI build failure: https://github.com/BurntSushi/rust-snappy/runs/2751122501?check_suite_focus=true

The failing tests are tests that check that this library generates the same compressed output as the reference Snappy C++ implementation. So a failing test here doesn't necessarily indicate a correctness issue, but that perhaps the reference implementation changed or got some improvements that we should investigate.

My next steps would probably be:

For now, I've disabled running the cpp roundtrip tests on macOS in CI.

Icelk commented 2 years ago

This also occurs on Linux x64:

rust-snappy/test ❯ cargo test --all-features

...

failures:
    tests::qc_cmpcpp
    tests::random2::cmpcpp
    tests::random3::cmpcpp
    tests::random4::cmpcpp