search

ByteArena / box2d

Box2D.go - Go port of Box2D - a 2D Physics Engine for Games.
Other
295 stars 48 forks source link

B2ShapeCast #21

Open Alexander-r opened 4 years ago

Alexander-r commented 4 years ago

Perform a linear shape cast of shape B moving and shape A fixed. Determines the hit point, normal, and translation fraction.

Ported from upstream.

xtuc commented 4 years ago

Could you please add a few test cases? Ideally the same than upstream

Alexander-r commented 4 years ago

I will look into adding tests. This was a rather recent addition so I have not checked how to use it.

But right now on go 1.13.7 all the tests fail because of Printf formatting. Maybe I should fix the formatting for existing tests first?

netgusto commented 4 years ago

Hey @Alexander-r I went ahead and proposed a PR fixing the issue you put forward on go 1.13. Thanks for doing so!

netgusto commented 4 years ago

I merged #24 into master. Tests should be good on go 1.13 now if you rebase.

Alexander-r commented 4 years ago

Would something like that be enough for a test? This is based on https://github.com/erincatto/box2d/blob/master/samples/tests/shape_cast.cpp but without actual drawing.

My C++ version for comparing the output: https://gist.github.com/Alexander-r/937980a0bf7f04d8335db71f17b65d1d