Closed jdh-observer closed 1 year ago
Md file has been generated https://github.com/jdh-observer/jdh002-VeaK58WBs82C/blob/main/article-notebook.md , can be the moment to evaluate the solution https://github.com/C2DH/journal-of-digital-history-backend/issues/175
It seems like the author forgot to finish the sentence here:
@inactinique how should we proceed with that question?
@biumiamy merge branch made / in order to consolidate the md file and the ipynb: the notebook need to be relaunch in the Jupyter server- DONE / desanonymisation done social media need to be generated
@inactinique copyright need to be requested and validation of the order of authors
Sent a mail asking:
I think that's all, right?
@inactinique Integration of the authors remarks
TO BE PUBLISH: @biumiamy
There's a dot at the end of the title. Do we want that?
No, we don't
Envoyé à partir de Outlook pour Androidhttps://aka.ms/AAb9ysg
From: Mirjam Pfeiffer @.> Sent: Thursday, March 9, 2023 2:13:00 PM To: C2DH/jdh-notebook @.> Cc: Frédéric CLAVERT @.>; Mention @.> Subject: Re: [C2DH/jdh-notebook] Integrate copy-editing Fifty Years of Technocracy. International Migration Management as an Evolving Discourse Coalition + Design review (Issue #104)
There's a dot at the end of the title. Do we want that?
[2023-03-09 14_12_00-Journal of Digital History]https://user-images.githubusercontent.com/47319502/224033541-616cfc4d-eaed-4885-bdfc-5088d3ddfb18.png
— Reply to this email directly, view it on GitHubhttps://github.com/C2DH/jdh-notebook/issues/104#issuecomment-1462045571, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAHYLLBPXQQTVMMTJ7Z5U23W3HJNZANCNFSM6AAAAAAVQ3KERY. You are receiving this because you were mentioned.Message ID: @.***>
I deleted the dot and added the social media cover to the repo. Now testing the figures in various browsers
I can only test Firefox and Chrome. Safari is not developed for Windows anymore I just learned xD
Well yes. As Elisabeth already said, they have scrollbars in Chrome and Firefox. But otherwise there's no issue.
So, Design Review done.
Scrollbars in safari too. If design review is done, then let's publish, so that I can send the authors the URL for a last review and we'll communicate next week.
@inactinique In production https://journalofdigitalhistory.org/en/article/VeaK58WBs82C
https://github.com/jdh-observer/jdh002-VeaK58WBs82C
Integration copy editing + design review + produce social media cover 50yearsofTechnocracy-AOD review v1.docx