C2DH / jdh-notebook

A collection of Jupyter notebooks for the Journal of Digital History
https://journalofdigitalhistory.org
GNU Affero General Public License v3.0
4 stars 1 forks source link

Technical review The Text Analysis Prototype for Galileo's Library and Letters Online: GaLiLeO #108

Closed eliselavy closed 10 months ago

eliselavy commented 1 year ago

Repository: https://github.com/jdh-observer/FYjDViXVXggz

eliselavy commented 11 months ago

Check html retrieve this:

<br>_Galileo’s Correspondence_
- Hannah Marcus and Paula Findlen: metadata and tagging schema of letters
- Data curators: Hannah Marcus, Daniele Macuglia, Rachel Midura, Mackenzie Cooley, Paolo Savoia, Demetrius Loufas, Brian Brege, Padraic Rohan, Chris Bacich, Julia Roever, Charlotte Thun-Hohenstein
- Undergraduate assistants: Kyle Lee-Crossett, Max Morales
- Morgan MacLeod: Python tools for tag analysis

<br> _Galileo’s Library_
- Crystal Hall: GaLiLeO infrastructure & tool development, corpus integration, library and correspondence document gathering, text cleaning, analysis, documentation, coordination with Harvard IT support for the workshop in September 2018.
- Aaron Gilbreath, Academic Tecnology & Consulting, Bowdoin College: experimental shiny app design for visualizing descriptions of the corpus (no longer supported)
- Additional transcribers and text cleaners: Gabriella Papper ’18, Dean Zucconi ’19, Ingrid Horton (MAI Services)

<br> _Workshop Support_
- William Barthelemy, Academic Technology, Harvard University Institutional Technology
found in the cell: <div class="cite2c-biblio"></div>

problem to run the preflight action : https://github.com/jdh-observer/FYjDViXVXggz/actions/runs/6262624601/workflow

biumiamy commented 10 months ago

Just saw this when I did a table check of all notebooks (if the formatting is still correct after Daniele created the dialog CSS adaption)

I remember we had similar case before... but I dont remember which article, nor how long ago..

Image

eliselavy commented 10 months ago

@biumiamy due to R notebook https://journalofdigitalhistory.org/en/article/MyifnvNPDgUx?idx=61 Screenshot 2023-10-16 at 16 00 45

eliselavy commented 10 months ago

Problem with myBinder:

"aux": {"ID": "sha256:c69b736b03915f18496f03e0d84e59a621767797ecb1ae229373cd0ca96affd6"}}Successfully built c69b736b0391
Successfully tagged gesiscss/binder-r2d-g5b5b759-jdh-2dobserver-2dfyjdvixvxggz-a9dda8:fac2a97db1a0f4ec6bf5790914fbb03f1b2e595f
Error during build: UnixHTTPConnectionPool(host='localhost', port=None): Read timed out.
eliselavy commented 10 months ago

By running nbconvert - error: https://app.reviewnb.com/jdh-observer/FYjDViXVXggz/pull/2/

Screenshot 2023-10-19 at 16 50 27 Screenshot 2023-10-19 at 16 50 41
eliselavy commented 10 months ago
Error in grid.Call(C_textBounds, as.graphicsAnnot(x$label), x$x, x$y, : polygon edge not found
Traceback:

plot without title
eliselavy commented 10 months ago

Debug in R - same problem Control of the list:

> length(type_attributes)
[1] 75798

Control of type_attributes[["ochiale"]]

$DocLevel
           ID    GG Year
 1:  EdNaz299 NotGG 1610
 2:  EdNaz574 NotGG 1611
 3: EdNaz1719 NotGG 1625
 4: EdNaz2015 NotGG 1630
 5:  EdNaz651 NotGG 1612
 6:  EdNaz666 NotGG 1612
 7:  EdNaz718 NotGG 1612
 8:  EdNaz729 NotGG 1612
 9:  EdNaz736 NotGG 1612
10:  EdNaz753 NotGG 1612
11:  EdNaz273 NotGG 1610
12:  EdNaz601 NotGG 1611
13:  EdNaz632 NotGG 1611

Test barplot / ggplot

Screenshot 2023-10-23 at 15 23 30

library(ggplot2) loads the package into your current R session.

but running nbconvert:

Error in grid.Call(C_textBounds, as.graphicsAnnot(x$label), x$x, x$y, : polygon edge not found
Traceback:

ERROR: Error in grid.Call(C_textBounds, as.graphicsAnnot(x$label), x$x, x$y, : polygon edge not found
eliselavy commented 10 months ago

By using this code no more error:

to set the x-axis use this: xlab("Year") in order to use: theme(axis.title.x=element_text("Year"))

eliselavy commented 10 months ago

Check mybinder - loaded correctly image FROM rocker/binder:4 Screenshot 2023-10-24 at 16 25 20 Screenshot 2023-10-24 at 16 25 20

eliselavy commented 10 months ago

Sent to peer-review