Remerge last revision for A Digital Toolbox for Studying the LGBTQ World, 1965-1990

[eliselavy]

https://github.com/jdh-observer/X3MGSKqAycaT

[eliselavy]

• CHECK RESSOURCES

  file demo_files/rstudio_leaflet-1.3.1/rstudio_leaflet.css is not called file demo_files/rstudio_leaflet-1.3.1/images/1px.png is not called file demo_files/leaflet-binding-2.1.2/leaflet.js is not called file demo_files/htmlwidgets-1.6.2/htmlwidgets.js is not called file demo_files/leafletfix-1.0.0/leafletfix.css is not called file demo_files/jquery-1.12.4/jquery.min.js is not called file demo_files/proj4-2.6.2/proj4.min.js is not called file demo_files/Proj4Leaflet-1.0.1/proj4leaflet.js is not called file demo_files/leaflet-1.3.1/leaflet.js is not called file demo_files/leaflet-1.3.1/leaflet.css is not called file demo_files/leaflet-1.3.1/images/layers.png is not called file demo_files/leaflet-1.3.1/images/marker-icon.png is not called file demo_files/leaflet-1.3.1/images/marker-icon-2x.png is not called file demo_files/leaflet-1.3.1/images/marker-shadow.png is not called file demo_files/leaflet-1.3.1/images/layers-2x.png is not called file media/typicallisting.png is not called file media/placeholder.png is not called

• Not anonymised

• Reference to the GitHub repository of the author

[eliselavy]

• Anonymisation made
• Generate Bibliography https://journalofdigitalhistory.org/en/notebook-viewer/JTJGcHJveHktZ2l0aHVidXNlcmNvbnRlbnQlMkZqZGgtb2JzZXJ2ZXIlMkZYM01HU0txQXljYVQlMkZtZXJnZSUyRmFydGljbGUuaXB5bmI=

But problem dataframe empty in the last version provided see: https://app.reviewnb.com/jdh-observer/X3MGSKqAycaT/pull/1/

@regan008 is the code should be commented as before?

[regan008]

@eliselavy Ah, there was an issue with the RDS dataset. I've fixed it and pushed the revisions. Now the code should run as expected.

[eliselavy]

@regan008 indeed the dataframe is no more empty but another problem:

• missing column status but I can remove the group by if needed

  

• Problem requires numeric latitude values

  

[regan008]

@eliselavy I think I fixed the data frame and pushed a revised version. Can you take another look?

[eliselavy]

@regan008 ok perfect it works locally / mybinder ok Your article can be send to the peer review. Don't forget to resynchronise with us, as some changes in metadata and tagging have been made. (cf label updated - metadata updated - tag the map, undefined reference) This issue goes to be implemented on our side https://github.com/C2DH/journal-of-digital-history/issues/533