Technical review Economic union in the debates on the creation of the euro: new evidence from the tapes of the Delors Committee meetings

[eliselavy]

https://github.com/jdh-observer/4ZDXFXQwhoA8

[eliselavy]

• no mention of libraries's version requirements.txt , need to be generated

• no test made for mybinder

• no change made in the template for the cover image, still placeholder

• NO LABEL defined for the table

• Design problem: url mentioned in the table of the figure

• Wrong tagging for the figures (from figure 9 to figure 19) and no figure-1

• Wrong tagging image

  

• Many ressources mentioned but not called (see output files ) but code for performing OCR on ECB textual documents NOT TESTED in the review

• Error running nbconvert due to missing NLP model , addition of the GitHub URL of the model to the requirements.txt

• Error running nbconvert problem version spacy with python version

  nbclient.exceptions.CellExecutionError: An error occurred while executing the following cell:
  200     # language subclass) while keeping top-level language identifier "lang"
  201     lang = meta.get("lang_factory", meta["lang"])
  --> 202     cls = get_lang_class(lang)
  203     nlp = cls(meta=meta, **overrides)
  204     pipeline = meta.get("pipeline", [])
  
   73     # Check if language is registered / entry point is available
  ---> 74     if lang in registry.languages:
   75         return registry.languages.get(lang)

[eliselavy]

Solve by adding : catalogue==2.0.8 catalogue package is a dependency of spacy, and is responsible for managing the available language models and pipeline components. this dependancy was not added by author and not found by using https://pypi.org/project/pipreqs/

[eliselavy]

Need to check error after nbconvert

[eliselavy]

Mybinder

Need to do a docker file: https://hub.docker.com/r/ibbd/spacy/dockerfile

[eliselavy]

Docker file didn't solve the issue: 2023-04-07T13:42:41Z [Normal] Created container notebook 2023-04-07T13:42:41Z [Normal] Started container notebook Spawn failed: Timeout Launch attempt 3 failed, retrying... Server requested 2023-04-07T13:47:53.168437Z [Normal] Successfully assigned prod/jupyter-jdh-2dobserver-2d4zdxfxqwhoa8-2d7fv5frr2 to gke-prod-user-202201-0769dbf8-fd9h 2023-04-07T13:47:54Z [Normal] Container image "jupyterhub/mybinder.org-tc-init:2020.12.4-0.dev.git.4289.h140cef52" already present on machine 2023-04-07T13:47:54Z [Normal] Created container tc-init 2023-04-07T13:47:54Z [Normal] Started container tc-init 2023-04-07T13:47:55Z [Normal] Pulling image "gcr.io/binderhub-288415/r2d-staging-g5b5b759-jdh-2dobserver-2d4zdxfxqwhoa8-4eb3aa:8eab35776044dfc2728a40e1aed4e452c4446f7b" 2023-04-07T13:48:49Z [Normal] Successfully pulled image "gcr.io/binderhub-288415/r2d-staging-g5b5b759-jdh-2dobserver-2d4zdxfxqwhoa8-4eb3aa:8eab35776044dfc2728a40e1aed4e452c4446f7b" in 54.794581341s 2023-04-07T13:48:50Z [Normal] Created container notebook 2023-04-07T13:48:50Z [Normal] Started container notebook Spawn failed: Server at http://10.0.20.141:8888/user/jdh-observer-4zdxfxqwhoa8-7fv5frr2/ didn't respond in 30 seconds Spawn failed: Server at http://10.0.20.141:8888/user/jdh-observer-4zdxfxqwhoa8-7fv5frr2/ didn't respond in 30 seconds

[eliselavy]

Related to https://github.com/C2DH/jdh-notebook/issues/117

[eliselavy]

Send to review