C2DH / jdh-notebook

A collection of Jupyter notebooks for the Journal of Digital History
https://journalofdigitalhistory.org
GNU Affero General Public License v3.0
4 stars 1 forks source link

Dialects of Discord. Changing vocabularies in the Dutch Cruise Missile discussion #113

Closed eliselavy closed 1 year ago

eliselavy commented 1 year ago

Take the branch : edited Look at reference / citation not rendered

GitHub repository: https://github.com/jdh-observer/jdh001-9HcfToh7EYm8 Preview: https://journalofdigitalhistory.org/en/notebook-viewer/JTJGcHJveHktZ2l0aHVidXNlcmNvbnRlbnQlMkZqZGgtb2JzZXJ2ZXIlMkZqZGgwMDEtOUhjZlRvaDdFWW04JTJGbWFpbiUyRnNraW0tYXJ0aWNsZS5pcHluYg== Article: https://github.com/jdh-observer/jdh001-9HcfToh7EYm8/blob/main/skim-article.ipynb

eliselavy commented 1 year ago

@inactinique licence saved in atlas directory - don't know if article required copy-editing @biumiamy please integrate social media in the repository https://github.com/jdh-observer/jdh001-9HcfToh7EYm8 design review to do GitHub repository: https://github.com/jdh-observer/jdh001-9HcfToh7EYm8 Preview: https://journalofdigitalhistory.org/en/notebook-viewer/JTJGcHJveHktZ2l0aHVidXNlcmNvbnRlbnQlMkZqZGgtb2JzZXJ2ZXIlMkZqZGgwMDEtOUhjZlRvaDdFWW04JTJGbWFpbiUyRnNraW0tYXJ0aWNsZS5pcHluYg== Article: https://github.com/jdh-observer/jdh001-9HcfToh7EYm8/blob/main/skim-article.ipynb If change needs to be done in the notebook: https://github.com/jdh-observer/jdh001-9HcfToh7EYm8/blob/main/1_load_train_7075.ipynb and action needs to be re-run https://github.com/jdh-observer/jdh001-9HcfToh7EYm8/actions/workflows/github-actions-publishing.yml

Take care to not alter metadata kernel spec - to submit to review to me if needed

Screenshot 2023-05-17 at 12 56 51

eliselavy commented 1 year ago

@inactinique please look at article

inactinique commented 1 year ago

Sent an email to Andy. We'll see his answer.

biumiamy commented 1 year ago

social media cover integrated

eliselavy commented 1 year ago

Need to provide a version to Andy in order to perform the copy-editing. Student Céline will integrate the changes in Md and push it on Github

eliselavy commented 1 year ago

By runnning nbconvert Screenshot 2023-06-12 at 17 35 45 Need to put contributor/ copyright cell in code mode 1_load_train_7075.pdf

eliselavy commented 1 year ago

article.pdf will be sent to Andy

eliselavy commented 1 year ago

@biumiamy Dialectics of Discord - article -AOD review v1.docx.zip Comment of Andy need to be integrated in the markdown file here: https://github.com/jdh-observer/jdh001-9HcfToh7EYm8/blob/main/1_load_train_7075.md

eliselavy commented 1 year ago

@inactinique @biumiamy takes charge on it. Review design - publication scheduled before the board meeting 29/06

biumiamy commented 1 year ago

corrections are done

biumiamy commented 1 year ago

Is there a way to extend the size of the popover? It's strange having to scroll when it's so little text anyway

2023-06-21 11_02_57-Journal of Digital History

biumiamy commented 1 year ago

@danieleguido The button to switch to the H-layer looks good when it's a few lines of text, but not when it's just one line (then the fade out is not working also.. and the text just overlaps and it looks like a weird error)

2023-06-21 11_04_47-Journal of Digital History

inactinique commented 1 year ago

Is there a way to extend the size of the popover? It's strange having to scroll when it's so little text anyway

2023-06-21 11_02_57-Journal of Digital History

And it should be jdh002 not jdh 003.

eliselavy commented 1 year ago

@inactinique jdh003 is in development as i created an Issue "Varia review" but in production would be jdh002 About the citation strange i don't have it, any idea @danieleguido Screenshot 2023-06-22 at 09 47 47

inactinique commented 1 year ago

@inactinique jdh003 is in development as i created an Issue "Varia review" but in production would be jdh002 About the citation strange i don't have it, any idea @danieleguido Screenshot 2023-06-22 at 09 47 47

Thanks, I thought it was something like that. On my computer: the citation appears with no scrollbar with firefox, chrome and safari (macos)

danieleguido commented 1 year ago

Hello, not sure I understand what's needed :D I'm a little bit lost @inactinique @eliselavy

eliselavy commented 1 year ago
danieleguido commented 1 year ago

ah ok, thanks for the explanation. Do we also need to fix the "Cite as" component?

eliselavy commented 1 year ago

Fixed

Screenshot 2023-06-26 at 18 09 50

Plot needs to be regenerated:

Screenshot 2023-06-26 at 18 10 29
eliselavy commented 1 year ago

In production https://journalofdigitalhistory.org/en/article/9HcfToh7EYm8

biumiamy commented 1 year ago

not yet published on DeGruyter