C2DH / jdh-notebook

A collection of Jupyter notebooks for the Journal of Digital History
https://journalofdigitalhistory.org
GNU Affero General Public License v3.0
4 stars 1 forks source link

Technical review Unlinked: Conflict Resolution and Structural Balance in the Early Modern Republic of Letters #130

Closed eliselavy closed 5 months ago

eliselavy commented 10 months ago

nKMX2DnFTBvx

https://github.com/jdh-observer/nKMX2DnFTBvx

Article sent for review 15 september

inactinique commented 6 months ago

Je prends le relais

inactinique commented 6 months ago

Added: GitHub Actions Ipynb for preflight that did not exist in this repo.

Ran without any problems

inactinique commented 6 months ago

launch of mybinder failed:

Warning in install.packages("ggplot2", "tidyverse", "dplyr", "igraph", "threejs", : 'lib = "tidyverse"' is not writable Error in install.packages("ggplot2", "tidyverse", "dplyr", "igraph", "threejs", : unable to install packages Execution halted

inactinique commented 6 months ago

@eliselavy cannot do the reproducible code part for now.

edit: iin fact started to but the version of R is missing. Will contact the author.

eliselavy commented 6 months ago

@inactinique ok go to look at but

install.packages function in R accepts only one package name at a time it means https://github.com/jdh-observer/nKMX2DnFTBvx/blob/main/install.R not valid (On package per line) https://github.com/jdh-observer/jdh001-9HcfToh7EYm8/blob/main/install.R

The version of R is defined in the Dockerfile.

I will look. Today i am Hpc workshop

inactinique commented 6 months ago

@eliselavy yep, you're right. Modified it and mybinder is now working. But code for now hard to reproduce, because R version misses.

eliselavy commented 5 months ago

Here to look at https://observablehq.com/collection/@jacomyma/quest-for-connected-closeness

jdh-observer commented 5 months ago

from the author:

R version 4.2.0 (2022-04-22) nickname Vigorous Calisthenics

eliselavy commented 5 months ago

Sent for review