C2DH / jdh-notebook

A collection of Jupyter notebooks for the Journal of Digital History
https://journalofdigitalhistory.org
GNU Affero General Public License v3.0
4 stars 1 forks source link

Technical review after R1: Economic union in the debates on the creation of the euro: new evidence from the tapes of the Delors Committee meetings #138

Closed inactinique closed 8 months ago

inactinique commented 10 months ago

pid: https://github.com/jdh-observer/4ZDXFXQwhoA8

(see author's email from 6.11.2023)

https://github.com/C2DH/jdh-notebook/issues/112

eliselavy commented 8 months ago

@inactinique revision merge - sent for peer-review again - pdf generated for copy-editing send to jdh.admin@uni.lu https://app.reviewnb.com/jdh-observer/4ZDXFXQwhoA8/pull/1/


need to fix mybinder as now ressources is back- no more MyBinder trouble: get a plain text "500 Internal Server Error"

This may mean that the package is missing, has been obsoleted, or
is only available from another source
However the following packages replace it:
  python-dev-is-python3

E: Package 'python-dev' has no installation candidate
Removing intermediate container dfbef9c665cd
The command '/bin/sh -c mkdir -p /var/www     &
eliselavy commented 8 months ago

@inactinique review of the label of figure / table , bad effect of nbreview can not check metadata, after merge for R1, authors didn't resynchronize with jdh-observer. Label restored now

Try to use the data-table-* tag, good use case with the 70 topics at the table-8 , see comment: https://github.com/C2DH/journal-of-digital-history/issues/575#issuecomment-1888789384

Screenshot 2024-01-12 at 10 58 18
eliselavy commented 8 months ago

From the metadata of the notebook retrieve version of python use by author: version": "3.10.6" Version of spacy not good , apparently 3.5 used

Still problem with installation of encountering an error related to the missing 'Eigen/Dense' file while trying to install Tomotopy library.

src/Labeling/../TopicModel/../Utils/serializer.hpp:10:10: fatal error: 'Eigen/Dense' file not found
  #include <Eigen/Dense>
           ^~~~~~~~~~~~~
  1 error generated.
  error: command '/usr/bin/clang' failed with exit code 1
  [end of output]
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
Cell In[6], line 34
     31 from gensim import corpora
     32 import gensim
---> 34 import tomotopy as tp
     36 # python3 -m spacy download en_core_web_sm
     37 nlp = spacy.load('en_core_web_sm')

ModuleNotFoundError: No module named 'tomotopy'
eliselavy commented 8 months ago

Test binder by : https://jdh-binder.curvenote.dev/v2/gh/jdh-observer/4ZDXFXQwhoA8/convert-R1?filepath=delors_anonymised.ipynb

No problem with the tomotopy library with version runtime defined and requirements.txt But: AttributeError: 'XlsxWriter' object has no attribute 'save' writer.close() instead writer.save()

plt.show() code don't work

But:

inactinique commented 8 months ago

Sent to copy-editing