technical review - Githubissues

C2DH / jdh-notebook

A collection of Jupyter notebooks for the Journal of Digital History

https://journalofdigitalhistory.org

GNU Affero General Public License v3.0

4 stars 1 forks source link

technical review #14

Closed jdh-observer closed 3 years ago

jdh-observer commented 3 years ago

perform technical review for https://github.com/jdh-observer/jdh001-WBqfZzfi7nHK

jdh-observer commented 3 years ago

Missing output directory
Addition requirements.txt
Postbuild files

eliselavy commented 3 years ago

Problem time execution and size of the ouput generated files

Screenshot 2021-06-14 at 18 04 23

eliselavy commented 3 years ago

need to update hermeneutics section link as an anchor see issue https://github.com/C2DH/journal-of-digital-history/issues/107

eliselavy commented 3 years ago

Locally time to read the EDCS dataset ==48s With myBinder : Problem by executing via myBinder

Screenshot 2021-06-17 at 13 43 18

eliselavy commented 3 years ago

https://jakevdp.github.io/PythonDataScienceHandbook/01.07-timing-and-profiling.html

eliselavy commented 3 years ago

While running on mybinder, users are guaranteed at least 1GB of RAM, with a maximum of 2GB. The cell to read the EDCS dataset: peak memory: 3113.20 MiB, increment: 2940.26 MiB. by using %%memit 3113.20 MiB = 3,264217088 GB

eliselavy commented 3 years ago

Screenshot 2021-06-17 at 14 45 30