C2DH / jdh-notebook

A collection of Jupyter notebooks for the Journal of Digital History
https://journalofdigitalhistory.org
GNU Affero General Public License v3.0
4 stars 1 forks source link

Design review - copy editing Economic union in the debates on the creation of the euro: new evidence from the tapes of the Delors Committee meetings #143

Closed eliselavy closed 9 months ago

eliselavy commented 9 months ago

Repository here: https://github.com/jdh-observer/4ZDXFXQwhoA8

@biumiamy

@eliselavy

@inactinique - @eliselavy

inactinique commented 9 months ago

After email exchange with authors,cover image might be for instance: https://www.ecb.europa.eu/ecb/access_to_documents/archives/delors/documents/shared/data/ecb.dr.delors880916_TranscriptionFirstMeeting.en.pdf?5d01ca39f8b12f73e7e476eb5986518a

eliselavy commented 9 months ago

Generate skim-article.ipynb to have proper size of the image, notice problem on the size of the label

Image

This action needs to be re-run each time there is an update to the article.ipynb Table-8 is a data-table to be tested on Windows @biumiamy

biumiamy commented 9 months ago

I propose for the link in the figure to change it to this: Excerpt from the handwritten notes of Gunter Baer of the third meeting of the Delors Committee, 8 November 1988

biumiamy commented 9 months ago

When I wanted to finish the corrections on Monday, I couldnt clone the repo

2024-02-01 08_18_14-GitHub Desktop

So instead I just downloaded only the article.md file and did the corrections there:

article.md

Some questions remain open:

eliselavy commented 9 months ago

@inactinique about the remarks of Andy see (previous comment made by @biumiamy ) don't know if reviewer made a comment

By looking on internet: about the snake seems to come from this concept: snake in the tunnel

At the 1972 Paris Summit, the EU attempted to impart fresh momentum to monetary integration by creating the ‘snake in the tunnel’: a mechanism for the managed floating of currencies (the ‘snake’) within narrow margins of fluctuation against the dollar (the ‘tunnel’). Thrown off course by the oil crises, the weakness of the dollar and differences in economic policy, the ‘snake’ lost most of its members in less than two years and was finally reduced to a ‘mark area’ comprising Germany, the Benelux countries and Denmark.

Do you need to to contact the author?

About Economic is already in the keywords

Image

eliselavy commented 9 months ago

When I wanted to finish the corrections on Monday, I couldnt clone the repo

2024-02-01 08_18_14-GitHub Desktop

You could:

Image

Image

eliselavy commented 9 months ago

@biumiamy reopen no social cover

eliselavy commented 9 months ago

Problem by pairing the notebook with the markdown see here:

Image

OK fixed need really to save the notebook

Image

eliselavy commented 9 months ago

@inactinique copy-editing integrated https://journalofdigitalhistory.org/en/notebook-viewer/JTJGcHJveHktZ2l0aHVidXNlcmNvbnRlbnQlMkZqZGgtb2JzZXJ2ZXIlMkY0WkRYRlhRd2hvQTglMkZtYWluJTJGc2tpbS1hcnRpY2xlLmlweW5i

@biumiamy fingerprint regenerated @inactinique wait for the feedback about snake

inactinique commented 9 months ago

@inactinique about the remarks of Andy see (previous comment made by @biumiamy ) don't know if reviewer made a comment

By looking on internet: about the snake seems to come from this concept: snake in the tunnel

At the 1972 Paris Summit, the EU attempted to impart fresh momentum to monetary integration by creating the ‘snake in the tunnel’: a mechanism for the managed floating of currencies (the ‘snake’) within narrow margins of fluctuation against the dollar (the ‘tunnel’). Thrown off course by the oil crises, the weakness of the dollar and differences in economic policy, the ‘snake’ lost most of its members in less than two years and was finally reduced to a ‘mark area’ comprising Germany, the Benelux countries and Denmark.

Do you need to to contact the author?

About Economic is already in the keywords

Image

Basically, following the Werner Committee, the member of the EEC put in place a monetary system between their currencies (including the currencies of the then --1972-- soon to be members but not yet members --Irland, UK and Denmark). That was the European Monetary Snake (not sure of the name in English, I need to check). It almost failed immmediatly, and was reduced to a couple of currencies around the DMark in a couple of years. That's what they are talking about.

Having said that, I think for readers that are not used to EEC monetary history might not understand, like Andy, what 'snake' refers to. So I suggest to write 'Snake' with a capitalized 'S' and to put into brackets the date [1972]: « as he reviews progress since the Snake [1972]... »

eliselavy commented 9 months ago

correction integrated https://journalofdigitalhistory.org/en/notebook-viewer/JTJGcHJveHktZ2l0aHVidXNlcmNvbnRlbnQlMkZqZGgtb2JzZXJ2ZXIlMkY0WkRYRlhRd2hvQTglMkZtYWluJTJGc2tpbS1hcnRpY2xlLmlweW5i

inactinique commented 9 months ago

Great. We also need to remove the "references" section at the end.

Untitled3
eliselavy commented 9 months ago

done - keep open @biumiamy social media cover

biumiamy commented 9 months ago

social media cover added: https://github.com/jdh-observer/4ZDXFXQwhoA8/blob/main/socialmediacover.png

eliselavy commented 9 months ago

Mistake by referencing the issue in the commit (mentioned #144 / was #143)

Only difference

https://github.com/jdh-observer/4ZDXFXQwhoA8/pull/4#discussion_r1486396487

eliselavy commented 9 months ago

@inactinique version final to send to the author: https://journalofdigitalhistory.org/en/notebook-viewer/JTJGcHJveHktZ2l0aHVidXNlcmNvbnRlbnQlMkZqZGgtb2JzZXJ2ZXIlMkY0WkRYRlhRd2hvQTglMkZtYWluJTJGc2tpbS1hcnRpY2xlLmlweW5i

Screenshot 2024-02-12 at 17 22 26

Licence to be requested / tweet also

eliselavy commented 9 months ago

Curvenote binder instance no more available From myBinder Successfully pushed 2lmrrh8f.gra7.container-registry.ovh.net/mybinder-builds/r2d-g5b5b759jdh-2dobserver-2d4zdxfxqwhoa8-4eb3aa:17eb1a4b4544c26f73d59d4f5374028c59cbea49Exception ignored in: <function Application.del at 0x7ff9fe281090> Traceback (most recent call last): File "/usr/lib/python3.10/site-packages/traitlets/config/application.py", line 1065, in del File "/usr/lib/python3.10/site-packages/traitlets/config/application.py", line 1054, in close_handlers File "/usr/lib/python3.10/site-packages/traitlets/traitlets.py", line 687, in get File "/usr/lib/python3.10/site-packages/traitlets/traitlets.py", line 666, in get TypeError: 'NoneType' object is not callable

eliselavy commented 9 months ago

@inactinique ready to publish https://journalofdigitalhistory.org/en/notebook-viewer/JTJGcHJveHktZ2l0aHVidXNlcmNvbnRlbnQlMkZqZGgtb2JzZXJ2ZXIlMkY0WkRYRlhRd2hvQTglMkZtYWluJTJGc2tpbS1hcnRpY2xlLmlweW5i

eliselavy commented 9 months ago

@inactinique ready to publish ? Let's prepare the tweets ;-) https://journalofdigitalhistory.org/en/notebook-viewer/JTJGcHJveHktZ2l0aHVidXNlcmNvbnRlbnQlMkZqZGgtb2JzZXJ2ZXIlMkY0WkRYRlhRd2hvQTglMkZtYWluJTJGc2tpbS1hcnRpY2xlLmlweW5i

eliselavy commented 9 months ago

Article published