Design review - Integrate copy editing Eminent Chinese of the Shenbao (1872-1891). A digital investigation of news reporting and newspaper-making in late imperial China

[eliselavy]

Repo here:

https://github.com/jdh-observer/fwpktfFtn5jm

• Copy editing to be integrated:

fwpktfFtn5jm-2 AOD review.docx.zip

but as mentionned Andy @inactinique : There are corrections and questions. We need to discuss this.

[biumiamy]

here is the problem: @inactinique

[eliselavy]

@biumiamy MD generated https://github.com/jdh-observer/fwpktfFtn5jm/blob/main/article.md

[eliselavy]

Commit related to issue https://github.com/C2DH/jdh-notebook/issues/143 / mistake made by referencing issue

[biumiamy]

@biumiamy wait for author to do change first, then do/resubmit correction

[inactinique]

Pull request with slight changes to the text in order to answer what Andy's remark

[eliselavy]

@biumiamy copy-editing can be inserted now in the md files

[biumiamy]

Umm, is it the correct copyediting file? there's not a single correction in the docx..

[biumiamy]

Anyway I changed from American to British English: https://github.com/jdh-observer/fwpktfFtn5jm/pull/4

[biumiamy]

editorial point: figure 1 is really uncomfortable to look at with the grey background.. why not just white? And there's also the double Figure 1 - Figure 1 (and this pattern repeats for all figures and tables)

[biumiamy]

And very good example here: figure 5 / 1h and figure 6 / 2h (and more after that..)

[biumiamy]

I deleted the figure part from all captions (see PR)

[eliselavy]

need to be done also for the label of the table / problem in Toc also duplicate table-1

[eliselavy]

need to fixed reference

[eliselavy]

I deleted the figure part from all captions (see PR)

but it exists some reference in the text to be fixed

[eliselavy]

to remove

[eliselavy]

fix reference / tag / wrong cell / undefined ORCID solution for this @danieleguido ?

[eliselavy]

fix reference / tag / wrong cell / undefined ORCID solution for this @danieleguido ?

not many things you can do without breaking the link

[eliselavy]

To check where it comes from this