C2DH / jdh-notebook

A collection of Jupyter notebooks for the Journal of Digital History
https://journalofdigitalhistory.org
GNU Affero General Public License v3.0
4 stars 1 forks source link

Technical revision R1 Women in Early Modern Handwritten News: Random Walks and Semantic Wanderings in the Medici Archive #146

Closed eliselavy closed 5 months ago

eliselavy commented 5 months ago

https://github.com/jdh-observer/jnkqqTTKW8km

eliselavy commented 5 months ago

Problem of figures A , B , C , D not taken into account in the JDH Problem with the auto-incrementation

No labels for the tables https://github.com/jdh-observer/jnkqqTTKW8km/pull/2

eliselavy commented 5 months ago

Code needs to be reexecuted after insertion of R1

eliselavy commented 5 months ago

@inactinique version to review for the figures tagging here: https://github.com/jdh-observer/jnkqqTTKW8km/tree/review-R1

eliselavy commented 5 months ago

Import needs to be reinserted as the following block have been removed

Screenshot 2024-02-13 at 18 10 04

eliselavy commented 5 months ago

Codev has been removed

df = pd.read_csv('data/input/WomenMenAbsencePresence.csv')

Screenshot 2024-02-13 at 18 18 21

No more dataframe to execute this: Screenshot 2024-02-13 at 18 22 33

eliselavy commented 5 months ago

@inactinique code exexuted / cover added need to fixed this problem of figure tag as A, B, C,D

Or just fixed the table of content? can you look at?

Screenshot 2024-02-14 at 15 06 15

https://journalofdigitalhistory.org/en/notebook-viewer/JTJGcHJveHktZ2l0aHVidXNlcmNvbnRlbnQlMkZqZGgtb2JzZXJ2ZXIlMkZqbmtxcVRUS1c4a20lMkZtYWluJTJGcGFwZXIuaXB5bmI=?idx=86

On branch main , to create branch

inactinique commented 5 months ago

OK. Recreated the review-R1 branch. Will do the modifications now.

inactinique commented 5 months ago

So all tags + legends + references in the text are done. You can rerun (one cell seemed not working, don't know why as I did not run it) and then merge @eliselavy

eliselavy commented 5 months ago

@inactinique Resend for peer-review