C2DH / jdh-notebook

A collection of Jupyter notebooks for the Journal of Digital History
https://journalofdigitalhistory.org
GNU Affero General Public License v3.0
4 stars 1 forks source link

Technical review after R1: Simulating and visualising data in environmental history: Airborne dust concentration from the Belval plant in Luxembourg (1911-1997) #154

Closed inactinique closed 3 months ago

inactinique commented 3 months ago

PID: ZDFmmD3xv4S7

We can add to the scholarone thing the version with/without track changes in word format (without code) (attached).

Be carefull, in the author(s)'s repository, the letter to answer the reviewers is in two formats: one with anonymisation, one not anonymized.

Dust pollution paperfinal version anonymized.docx Dust pollution papertracked changes anonymized.docx

eliselavy commented 3 months ago

Review paper not anonymised Confusing three .ipynb

eliselavy commented 3 months ago

Author has changed the heading level again

Screenshot 2024-04-05 at 16 41 52

and before

Screenshot 2024-04-05 at 16 42 00
eliselavy commented 3 months ago

Problem my binder:

Waiting for build to start...
Picked Git content provider.
Cloning into '/tmp/repo2docker549ir9md'...
Updating files: 100% (1074/1074), done.
HEAD is now at 6b66ed4 Apply automatic changes
Building conda environment for python=3.7
Using PythonBuildPack builder
eliselavy commented 3 months ago

Problem no more figure 7: image_paths = sorted(glob("./media/figure7*_72.png"))

eliselavy commented 3 months ago

Problem mybinder due to the size of the script folder > 2GB Message posted on the forum for having an explicit message: https://discourse.jupyter.org/t/lauching-github-repo-into-binder-fails-due-to-script-folder-2gb-message-could-be-more-explicit/25062

eliselavy commented 3 months ago

Sent for review