Technical review after R2: Mapping radio: Variations on segmentation and analysisof Swedish broadcasting data: Decision Revise with Major Modifications

C2DH / jdh-notebook

A collection of Jupyter notebooks for the Journal of Digital History

https://journalofdigitalhistory.org

GNU Affero General Public License v3.0

4 stars 1 forks source link

Technical review after R2: Mapping radio: Variations on segmentation and analysisof Swedish broadcasting data: Decision Revise with Major Modifications #156

Closed inactinique closed 3 months ago

inactinique commented 3 months ago

PID: 6EWgjJtoiW6R

https://github.com/jdh-observer/6EWgjJtoiW6R

Author updated their repository

see abstract in backend for repository URL
be careful, title has changed: "Experiments on the threshold between signals and narratives: Two methods of audio analysis and their implications for historiography." in backend.

eliselavy commented 3 months ago

problem table of contents

eliselavy commented 3 months ago

Problem mybinder: ImportError: Numba needs NumPy 1.22 or greater. Got NumPy 1.21.

eliselavy commented 3 months ago

Problem mybinder: ImportError: Numba needs NumPy 1.22 or greater. Got NumPy 1.21.

but i need to have numpy <= 1.20 due to

AttributeError: module 'numpy' has no attribute 'complex'.
`np.complex` was a deprecated alias for the builtin `complex`. To avoid this error in existing code, use `complex` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.complex128` here.

eliselavy commented 3 months ago

https://app.reviewnb.com/jdh-observer/6EWgjJtoiW6R/pull/3/

eliselavy commented 3 months ago

difference between csv file but author update file Mar 29, 2023 and us synchronize in December 2023 : https://github.com/jdh-observer/6EWgjJtoiW6R/commit/4d873bb41282825edd1341675909886f6d4002ee

need to rerun code

inactinique commented 3 months ago

Je regarde, mais je crois que c’est normal. J’essaye de voir ça demain.

From: eliselavy @.> Date: Wednesday, 3 April 2024 at 18:58 To: C2DH/jdh-notebook @.> Cc: Frédéric CLAVERT @.>, Author @.> Subject: Re: [C2DH/jdh-notebook] Technical review after R2: Mapping radio: Variations on segmentation and analysisof Swedish broadcasting data: Decision Revise with Major Modifications (Issue #156)

difference between csv file but author update file Mar 29, 2023 and us synchronize in December 2023 : @.***https://github.com/jdh-observer/6EWgjJtoiW6R/commit/4d873bb41282825edd1341675909886f6d4002ee

— Reply to this email directly, view it on GitHubhttps://github.com/C2DH/jdh-notebook/issues/156#issuecomment-2035117310, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAHYLLC3DL25MKOWCAX4OZ3Y3QYLDAVCNFSM6AAAAABFKIYH66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZVGEYTOMZRGA. You are receiving this because you authored the thread.Message ID: @.***>

eliselavy commented 3 months ago

We have the good version of the csv file (https://github.com/jdh-observer/6EWgjJtoiW6R/blob/main/script/audio_featuresmean.csv) - author repo not updated Execution myBinder OK Sent for review