C2DH / jdh-notebook

A collection of Jupyter notebooks for the Journal of Digital History
https://journalofdigitalhistory.org
GNU Affero General Public License v3.0
4 stars 1 forks source link

Copy editing / Technical / Design review after accept: Tracking and tracing audiovisual reuse #167

Open inactinique opened 4 months ago

inactinique commented 4 months ago

PID: BuWvtJFxh3wy

Last version of the article: https://github.com/humlab/vrd_submit

Comment from the authors:

There are still some layout issues that we’d like to ask you help us solve. The issues concern the rendering of images in our article and were described when we submitted the article, so perhaps you have already found a solution.

First, our images have a slightly unusual format (long strips) and currently, we believe that too much white space is shown around our image samples (see for example figure 3). Is there a way to fix this?

Second, we’d like to show a larger number of image samples in our hermeneutical layer although this creates a terrible reading experience at this stage. Previously, we therefore requested a feature for collapsing cell outputs into a scrollable cell, since this would make the layout much, much nicer. Is there a way to fix this too?

In paragraph 74 in the hermeneutics layer, you can find the following comment, which describes the issue in more detail:

“NOTE TO PEER REVIEWER FROM THE AUTHORS: if you are reading this in the journal’s preview/rendering of the article you will be shown a lot of sequence matches below. We are aware that this creates a terrible reading experience and apologize for the inconvenience. At the moment, we are having a dialogue with the journal editors regarding the possibility to collapse cell outputs into a scrollable cell, which would make it much easier to read the hermeneutical layer. If you are reading this in Jupyter notebook, you will get a sense of what we want it to look like. If the journal is unable to meet our request to implement scrollable cell outputs, we are prepared to seriously revise how much data/output is shown in the hermeneutical layer. For now, however, we let the data remain as it is.”

  1. Finally, we couldn’t quite get a reference in paragraph 13 to work properly for some mysterious reason. It concerns: (Erll and Rigney 2009, p. 4).

Erll, Astrid, and Ann Rigney. “Introduction: Cultural Memory and Its Dynamics.” In Mediation, Remediation and the Dynamics of Cultural Memory, edited by Astrid Erll and Ansgar Nünning, 1–11. Berlin: Walter de Gruyter GmbH & Co., 2009. https://doi.org/10.1515/angl.2010.024.

eliselavy commented 4 months ago

@inactinique no copy-editing for Andy?

inactinique commented 4 months ago

Yes, bad naming of the issue.

eliselavy commented 2 months ago

sent to copy-editing

eliselavy commented 1 month ago

@biumiamy version docx reviewed inserted

biumiamy commented 1 month ago

integrated, here's the PR

eliselavy commented 1 month ago

Merge correction - skim generated @biumiamy design review still this problem of number of images -need to test with V3 by running code also but article needs to be put in prod to start kernel

solution on collaspe panel?

eliselavy commented 1 week ago

recheck code in mybinder , following message to fixed ImportError: Missing optional dependency 'openpyxl'. Use pip or conda to install openpyxl.

eliselavy commented 1 week ago

recheck code in mybinder , following message to fixed ImportError: Missing optional dependency 'openpyxl'. Use pip or conda to install openpyxl.

fixed

eliselavy commented 1 week ago

In prod , citation to correct missing one author

eliselavy commented 1 week ago

Can be tested with V3, here @inactinique https://journalofdigitalhistory.netlify.app/en/article/BuWvtJFxh3wy?v=3

eliselavy commented 1 week ago

Can be tested with V3, here @inactinique https://journalofdigitalhistory.netlify.app/en/article/BuWvtJFxh3wy?v=3

Strange following error:

Screenshot 2024-09-26 at 13 41 07

but run before in mybinder, but now mybinder: 500: Internal Server Error

Now ok

Screenshot 2024-09-26 at 13 45 17
eliselavy commented 1 week ago

@danieleguido - @inactinique here i was playing with code, change from 10 frames to 2 frames

Screenshot 2024-09-26 at 13 47 35

but same space as before needs to scroll

Screenshot 2024-09-26 at 13 48 36 Screenshot 2024-09-26 at 13 48 54

We can put 2 frames and comment for the reader with the initial value to be executed to see it ?

Adjustement to this parapgraph:

We adjust the frame size and number of shown sequences and have a look at the final matching results. Note that the match mean distance values shown above the sequences may be higher than the previously set distance metric threshold. This is normal and expected, due to the merging of overlapping sequences.

NOTE TO PEER REVIEWER FROM THE AUTHORS: if you are reading this in the journal’s preview/rendering of the article you will be shown a lot of sequence matches below. We are aware that this creates a terrible reading experience and apologize for the inconvenience. At the moment, we are having a dialogue with the journal editors regarding the possibility to collapse cell outputs into a scrollable cell, which would make it much easier to read the hermeneutical layer. If you are reading this in Jupyter notebook, you will get a sense of what we want it to look like. If the journal is unable to meet our request to implement scrollable cell outputs, we are prepared to seriously revise how much data/output is shown in the hermeneutical layer. For now, however, we let the data remain as it is.

In fact the part demo, executable can be read in the journal.

The second part about Finding reuse in the SF archive with the biggest corpus, is not readable and can not be executed as the materials is so huge ( > 30 hours materials)

biumiamy commented 4 days ago
inactinique commented 4 days ago
  • @inactinique will write the disclaimer on top explaining the limitation

My proposal: « Note from the editors: this article is published within a beta version of our website design, to make the reader's experience better. In some code cells, a "show_limit" parameter can be changed by the reader if they want to display more images. »