C2DH / jdh-notebook

A collection of Jupyter notebooks for the Journal of Digital History
https://journalofdigitalhistory.org
GNU Affero General Public License v3.0
4 stars 1 forks source link

Copy editing / technical /design review after accept: Simulating and visualising data in environmental history: Airborne dust concentration from the Belval plant in Luxembourg (1911-1997) #168

Open inactinique opened 1 month ago

inactinique commented 1 month ago

PID: ZDFmmD3xv4S7

eliselavy commented 3 weeks ago

@inactinique Didn't take into account desanomization made by the authors

Screenshot 2024-06-11 at 17 42 54

align with:

Screenshot 2024-06-11 at 17 43 15 Screenshot 2024-06-11 at 18 20 50
eliselavy commented 3 weeks ago

@inactinique sent for copy-editing

eliselavy commented 3 weeks ago

@biumiamy copy-editing can be added https://github.com/jdh-observer/ZDFmmD3xv4S7/blob/main/article.md ZDFmmD3xv4S7.docx updated

biumiamy commented 3 weeks ago

done, PR here: https://github.com/jdh-observer/ZDFmmD3xv4S7/compare/corrections?expand=1

There is one editorial problem in my eyes: They used anchors to refer to sections of their article. But since we dont show those numbers, it's not very easy for readers to understand what they refer to (apart from clicking to jump there.. and then having to scroll back to where they were originally reading).

2024-06-14 09_02_05-Window

I recommend the authors to change this to sth that works better with our structure of the frontend. Reference to the name of the chapter or whatever..

Also:

eliselavy commented 3 weeks ago

done, PR here: https://github.com/jdh-observer/ZDFmmD3xv4S7/compare/corrections?expand=1

There is one editorial problem in my eyes: They used anchors to refer to sections of their article. But since we dont show those numbers, it's not very easy for readers to understand what they refer to (apart from clicking to jump there.. and then having to scroll back to where they were originally reading).

2024-06-14 09_02_05-Window

I recommend the authors to change this to sth that works better with our structure of the frontend. Reference to the name of the chapter or whatever..

Also:

  • videos not implemented (I can upload them to vimeo, but they need to decided where to put the videos.. and what text and figure title etc.)
  • images (and video make the repo size) too big, need to decrease in last step of design review

consolidation made - anchor works about the use of the section mention , the reviewer made any feedback about it @inactinique article here

eliselavy commented 2 weeks ago

@biumiamy social media cover

biumiamy commented 2 weeks ago

here are the two videos that are in their repo hosted on vimeo: pollution animation pollution Esch And I recommend to integrate the video from their website

(but actually the provided quality is very bad..)

biumiamy commented 2 weeks ago

@danieleguido the dot beside my mouse pointer is cut off for some reason

2024-06-18 15_41_50-Journal of Digital History

biumiamy commented 2 weeks ago

added social media cover: https://github.com/jdh-observer/ZDFmmD3xv4S7/blob/main/socialmediacover.png

inactinique commented 1 week ago

Hum. Some paragraphs are badly numbered.

Untitled 2
inactinique commented 1 week ago

here are the two videos that are in their repo hosted on vimeo: pollution animation pollution Esch And I recommend to integrate the video from their website

(but actually the provided quality is very bad..)

What should I precisely write to them in this respect? There are cells with ffmpeg, but not sure that it is displaying anything?

inactinique commented 1 week ago

Problem of this cell that should be in the hermeneutics layer:

Untitled 3

In the markdown fil, it is tagged hermeneutics. Maybe it's something already corrected.

biumiamy commented 6 days ago

What should I precisely write to them in this respect? There are cells with ffmpeg, but not sure that it is displaying anything?

There's only images implemented for the moment. And I dont know, where did you find those cells, I cant see them in Jupyter Lab at least..

Image

You can just ask them

inactinique commented 5 days ago

Isn't there that there should be the two videos? (ffmpeg code)

video1 video2