C2DH / jdh-notebook

A collection of Jupyter notebooks for the Journal of Digital History
https://journalofdigitalhistory.org
GNU Affero General Public License v3.0
4 stars 1 forks source link

Technical review for In search of an interpretative environment for digital traces: the building of Arvest #176

Open jdh-observer opened 1 month ago

jdh-observer commented 1 month ago

Technical review for In search of an interpretative environment for digital traces: the building of Arvest

pid : 8X2RX68Qavxr

https://github.com/jdh-observer/8X2RX68Qavxr

eliselavy commented 1 month ago

@danieleguido problem more than 12 columns , scroll in jupyter notebook not in front https://journalofdigitalhistory.org/en/notebook-viewer/JTJGcHJveHktZ2l0aHVidXNlcmNvbnRlbnQlMkZqZGgtb2JzZXJ2ZXIlMkY4WDJSWDY4UWF2eHIlMkZtYWluJTJGYXJ0aWNsZS5pcHluYg==?idx=30

advice?

Screenshot 2024-08-08 at 18 15 09

In v3? https://journalofdigitalhistory.netlify.app/en/notebook-viewer/JTJGcHJveHktZ2l0aHVidXNlcmNvbnRlbnQlMkZqZGgtb2JzZXJ2ZXIlMkY4WDJSWDY4UWF2eHIlMkZtYWluJTJGYXJ0aWNsZS5pcHluYg==?v=3

eliselavy commented 1 month ago

Missing label figures / tables

eliselavy commented 1 month ago
---> 12 display(Image("media/figure1.png", width=1000), metadata=metadata)
NameError: name 'Image' is not defined

https://github.com/jdh-observer/8X2RX68Qavxr/actions/runs/10321387424/job/28574168666

eliselavy commented 1 week ago

@biumiamy advices in order to reformat the columns

eliselavy commented 5 days ago

@biumiamy now the table will be a dataframe generated from a csv file see comments here before merge https://github.com/jdh-observer/8X2RX68Qavxr/pull/2

biumiamy commented 5 days ago

I think the best way finally is to set it up as a dataframe from scratch. Then it looks the best:

2024-09-10 16_41_13-Window

eliselavy commented 5 days ago

I think the best way finally is to set it up as a dataframe from scratch. Then it looks the best:

2024-09-10 16_41_13-Window

perfect indeed but maybe data can be loaded from the csv, where the formatted can be there Screenshot 2024-09-10 at 16 47 17

biumiamy commented 4 days ago

Okay I formatted a bit again. I think now it can be sent to the author @eliselavy https://journalofdigitalhistory.org/en/notebook-viewer/JTJGcHJveHktZ2l0aHVidXNlcmNvbnRlbnQlMkZqZGgtb2JzZXJ2ZXIlMkY4WDJSWDY4UWF2eHIlMkZ0YWJsZSUyRmFydGljbGUuaXB5bmI=