Open eliselavy opened 2 months ago
Sent for copy-editing
@biumiamy copy-editing can be inserted
very small corrections, only on pages 20 and 27
ok consolidation made I need to do the desanomization otherwise no design issue @biumiamy ?
I'm correcting missing spaces
And this makes no sense btw? maybe a citation got lost?
done. I did it in the md file https://github.com/jdh-observer/6ig87tC5GKjQ/pull/5
consolidation desanomysation made
citation is there in the notebook
but missing author in the metadata needs to recheck in zotero
"8820477/X9UECV7S": {
"id": "8820477/X9UECV7S",
"title": "Van Houtum and Van Naerssen - 2002 - Bordering, Ordering and Othering.pdf",
"type": "article"
},
consolidation desanomysation made
citation is there in the notebook
but missing author in the metadata needs to recheck in zotero
"8820477/X9UECV7S": { "id": "8820477/X9UECV7S", "title": "Van Houtum and Van Naerssen - 2002 - Bordering, Ordering and Othering.pdf", "type": "article" },
ok fixed
@biumiamy need to say if skim or not and look at media folder if some reduction can be made as article > 26MB
Skim and I reduced the file size of some of the biggest audio files: https://github.com/jdh-observer/6ig87tC5GKjQ/pull/7
I used this: https://www.xconvert.com/compress-m4v
good rerun nbconvert - now article 17,3MB against 26,3MB before
@inactinique article can be sent to author for final check: https://journalofdigitalhistory.org/en/notebook-viewer/JTJGcHJveHktZ2l0aHVidXNlcmNvbnRlbnQlMkZqZGgtb2JzZXJ2ZXIlMkY2aWc4N3RDNUdLalElMkZtYWluJTJGc2tpbS1hcnRpY2xlLmlweW5i @biumiamy - @inactinique article in production ( citation - fingerprint generated) available here: https://journalofdigitalhistory.org/en/article/6ig87tC5GKjQ
oups to remove
citation to fixed
oups to remove
fixed
Ah one question: didnt the author want the data-table here? at that time we didnt have it yet.. but it makes sense here maybe?
And for some reason this figure doesnt skim.. it feels like a deja vue. Maybe we talked about this before.
Otherwise the rest is okay from design side
citation to fixed
fixed
Ah one question: didnt the author want the data-table here? at that time we didnt have it yet.. but it makes sense here maybe?
@biumiamy please add it in the md and pull-request
And for some reason this figure doesnt skim.. it feels like a deja vue. Maybe we talked about this before.
Otherwise the rest is okay from design side
@biumiamy skim taken into account look at in the raw , tag are displayed, is there because image not enough height, minimal space planned , see sith @danieleguido },
"tags": [
"hermeneutics",
"figure-digital-history-practices-*",
"aspect-ratio-2222-1579",
"h-1579px",
"w-2222px"
]
https://raw.githubusercontent.com/jdh-observer/6ig87tC5GKjQ/main/skim-article.ipynb
did you use the new v3 @biumiamy ? This has been fixed there. The problem is that the image is stretched horizontally. Skim action just add the ratio of the image as a tag, and in V2 we didn't cover the case of such images
Ah one question: didnt the author want the data-table here? at that time we didnt have it yet.. but it makes sense here maybe?
@biumiamy please add it in the md and pull-request
done - data-table added to table-4 @biumiamy https://journalofdigitalhistory.org/en/article/6ig87tC5GKjQ?idx=146&layer=hermeneutics&lh=684&pidx=146
@biumiamy create a lightbox mockup for tables / images
solved the mystery around the cover img:
now its trimmed and shouldnt make any problems anymore ;)
found a way to combine cells of multiple mentioning PostID and -Text (but need to test if it works in v3 and how it looks like.. code uses html)
So above is a html table that can only show full length but it shows the different comment to the Posts much better. Below is our data-table.
So which is better?
@inactinique take a look here
data-table for me.
okay I found a way. I cleared up the clutter a bit so it's more readible here too..
I kept the PostID to make it easier to search:
@inactinique email sent to the author in order to implement their changes....