C2DH / jdh-notebook

A collection of Jupyter notebooks for the Journal of Digital History
https://journalofdigitalhistory.org
GNU Affero General Public License v3.0
4 stars 1 forks source link

Copy-editing - design review - Chronoferencing the Italian-Slovenian Borderlands. Citizen Science, Oral History and Output Criticism #178

Open eliselavy opened 2 months ago

eliselavy commented 2 months ago
eliselavy commented 2 months ago

Sent for copy-editing

eliselavy commented 2 months ago

@biumiamy copy-editing can be inserted

very small corrections, only on pages 20 and 27

biumiamy commented 2 months ago

done: https://github.com/jdh-observer/6ig87tC5GKjQ/pull/4

eliselavy commented 2 months ago

ok consolidation made I need to do the desanomization otherwise no design issue @biumiamy ?

biumiamy commented 2 months ago

I'm correcting missing spaces

2024-09-23 14_51_52-Journal of Digital History

And this makes no sense btw? maybe a citation got lost?

2024-09-23 14_50_50-Journal of Digital History

biumiamy commented 2 months ago

done. I did it in the md file https://github.com/jdh-observer/6ig87tC5GKjQ/pull/5

eliselavy commented 2 months ago

consolidation desanomysation made

citation is there in the notebook

Screenshot 2024-09-23 at 17 40 30

but missing author in the metadata needs to recheck in zotero

"8820477/X9UECV7S": {
        "id": "8820477/X9UECV7S",
        "title": "Van Houtum and Van Naerssen - 2002 - Bordering, Ordering and Othering.pdf",
        "type": "article"
      },
eliselavy commented 2 months ago

consolidation desanomysation made

citation is there in the notebook Screenshot 2024-09-23 at 17 40 30

but missing author in the metadata needs to recheck in zotero

"8820477/X9UECV7S": {
        "id": "8820477/X9UECV7S",
        "title": "Van Houtum and Van Naerssen - 2002 - Bordering, Ordering and Othering.pdf",
        "type": "article"
      },

ok fixed

Screenshot 2024-09-23 at 17 58 08
eliselavy commented 2 months ago

@biumiamy need to say if skim or not and look at media folder if some reduction can be made as article > 26MB

biumiamy commented 2 months ago

Skim and I reduced the file size of some of the biggest audio files: https://github.com/jdh-observer/6ig87tC5GKjQ/pull/7

I used this: https://www.xconvert.com/compress-m4v

eliselavy commented 2 months ago

good rerun nbconvert - now article 17,3MB against 26,3MB before

eliselavy commented 2 months ago

@inactinique article can be sent to author for final check: https://journalofdigitalhistory.org/en/notebook-viewer/JTJGcHJveHktZ2l0aHVidXNlcmNvbnRlbnQlMkZqZGgtb2JzZXJ2ZXIlMkY2aWc4N3RDNUdLalElMkZtYWluJTJGc2tpbS1hcnRpY2xlLmlweW5i @biumiamy - @inactinique article in production ( citation - fingerprint generated) available here: https://journalofdigitalhistory.org/en/article/6ig87tC5GKjQ

eliselavy commented 2 months ago

oups to remove

Screenshot 2024-09-25 at 10 05 05
eliselavy commented 2 months ago

citation to fixed

Screenshot 2024-09-25 at 10 04 57
eliselavy commented 2 months ago

oups to remove Screenshot 2024-09-25 at 10 05 05

fixed

biumiamy commented 2 months ago

Ah one question: didnt the author want the data-table here? at that time we didnt have it yet.. but it makes sense here maybe?

2024-09-25 14_31_33-Window

2024-09-25 14_31_39-Window

biumiamy commented 2 months ago

And for some reason this figure doesnt skim.. it feels like a deja vue. Maybe we talked about this before.

Otherwise the rest is okay from design side

2024-09-25 14_34_04-Window

eliselavy commented 2 months ago

citation to fixed Screenshot 2024-09-25 at 10 04 57

fixed

eliselavy commented 2 months ago

Ah one question: didnt the author want the data-table here? at that time we didnt have it yet.. but it makes sense here maybe?

2024-09-25 14_31_33-Window

2024-09-25 14_31_39-Window

@biumiamy please add it in the md and pull-request

eliselavy commented 2 months ago

And for some reason this figure doesnt skim.. it feels like a deja vue. Maybe we talked about this before.

Otherwise the rest is okay from design side

2024-09-25 14_34_04-Window

@biumiamy skim taken into account look at in the raw , tag are displayed, is there because image not enough height, minimal space planned , see sith @danieleguido },

"tags": [
          "hermeneutics",
          "figure-digital-history-practices-*",
          "aspect-ratio-2222-1579",
          "h-1579px",
          "w-2222px"
        ]

https://raw.githubusercontent.com/jdh-observer/6ig87tC5GKjQ/main/skim-article.ipynb

danieleguido commented 2 months ago

did you use the new v3 @biumiamy ? This has been fixed there. The problem is that the image is stretched horizontally. Skim action just add the ratio of the image as a tag, and in V2 we didn't cover the case of such images

eliselavy commented 2 months ago

Ah one question: didnt the author want the data-table here? at that time we didnt have it yet.. but it makes sense here maybe? 2024-09-25 14_31_33-Window 2024-09-25 14_31_39-Window

@biumiamy please add it in the md and pull-request

done - data-table added to table-4 @biumiamy https://journalofdigitalhistory.org/en/article/6ig87tC5GKjQ?idx=146&layer=hermeneutics&lh=684&pidx=146

biumiamy commented 1 month ago

2024-10-02 12_05_06-Window

biumiamy commented 1 month ago

@biumiamy create a lightbox mockup for tables / images

biumiamy commented 1 month ago

solved the mystery around the cover img:

2024-10-07 09_35_24-alternative_graph png @ 33 3% (RGB_8#)  scaled

now its trimmed and shouldnt make any problems anymore ;)

biumiamy commented 1 month ago

@danieleguido will add the dialog tag to v3 (#658)

biumiamy commented 1 month ago

found a way to combine cells of multiple mentioning PostID and -Text (but need to test if it works in v3 and how it looks like.. code uses html)

2024-10-07 20_28_13-article ipynb - JupyterLab

biumiamy commented 1 month ago

So above is a html table that can only show full length but it shows the different comment to the Posts much better. Below is our data-table.

2024-10-10 10_57_03-Journal of Digital History

So which is better?

biumiamy commented 1 month ago

@inactinique take a look here

inactinique commented 1 month ago

data-table for me.

biumiamy commented 1 month ago

okay I found a way. I cleared up the clutter a bit so it's more readible here too..

2024-10-14 21_20_18-Window

I kept the PostID to make it easier to search:

2024-10-14 21_20_12-Window

eliselavy commented 3 weeks ago

Version ready in v3 - dialog tag - image fixed link to V3 here.

eliselavy commented 3 weeks ago

@inactinique email sent to the author in order to implement their changes....