Technical review https://github.com/jdh-observer/jdh001-9HcfToh7EYm8

[eliselavy]

Email received from author

• need to integrate the datas
• mybinder testing

[eliselavy]

Email sent to the author in order to fix following problem: :

[eliselavy]

Problem with

[eliselavy]

Merge the new revision for the repository : https://github.com/jdh-observer/jdh001-9HcfToh7EYm8

[eliselavy]

I request also to a colleague working with RStudio on Windows as you ( I am on mac) to read the file send by email. Same error as me:

"Error in readRDS("~/Elisabeth/stuff.RDS") : error reading from connection" (même après avoir déclaré le folder comme directeur de travail avec setwd).

I execute the R’s script provided by email in version 4.1.0. A error occurs by reading the new version uploaded in your github ‘s repository see logs below:

But loading the file in R ‘s studio as requested, same error occurs:

As you noticed the difference of behavior doesn’t seem to linked to the R’s version but to the file as you can read it from your side, and not me.

What is the difference between these two files?

We have already a problem with reading files in the past, maybe we could have a Webex session in order to exchange about this and debug together?

[eliselavy]

Try now with .csv file : https://github.com/jdh-observer/jdh001-9HcfToh7EYm8/blob/main/parl_texts_7075.csv

[eliselavy]

CSV provided was not formatted in UTF-8 Try different way to read.csv but at the source was not correct => result can not be Several email exchange with the author

csv in UTF-8 has been provided - wait for the plot validation RDS need to be provided as reading csv in R take ages

[eliselavy]

Plot with files2 <- read.csv(text = files, encoding="UTF-8")

[eliselavy]

Result of the plot has been validated.

Now performance problem needs to be solved

Dedicated webex session planned to merge:

• https://github.com/jdh-observer/jdh001-9HcfToh7EYm8/blob/main/1_load_train_7075.ipynb
• https://github.com/jdh-observer/jdh001-9HcfToh7EYm8/blob/main/dialectsofdiscord.ipynb

[eliselavy]

Performance problem solved:

[eliselavy]

Appointment fixed for 22 June.

[eliselavy]

Notebook merged received.

• Fixed problem of cite2c key not inserted by copying markdown block
• Addition title / contributor / copyright tags
• Remove id in metadata: Notebook validation failed: Additional properties are not allowed ('id' was unexpected):

  {
  "metadata": {},
  "id": "42aecb07-62c2-4b84-9975-15db61ee568d",
  "cell_type": "markdown",
  "source": "## Introduction"
  } 

• Retest my binder

[eliselavy]

Can be send for review

[eliselavy]

Problem with one reference due to bug https://github.com/takluyver/cite2c/issues/52