Technical review https://github.com/jdh-observer/jdh002-VeaK58WBs82C

eliselavy commented 2 years ago

eliselavy commented 2 years ago

Configure requirements.txt Vega visualization to support

eliselavy commented 2 years ago

Issue https://github.com/C2DH/journal-of-digital-history/issues/341 to fixed

eliselavy commented 2 years ago

Altair is not available in preview
Problem to rerun the code as error occurred:

/scripts/datasets.py in download_spreadsheet_data(spreadsheet_url)
     90         return response.text
     91     else:
---> 92         raise ValueError(response.text)
     93 
     94 

ValueError: <!DOCTYPE html><html lang="de"><head><meta name="description" content="Textverarbeitung, Präsentationen und Tabellen im Web"><meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0, user-scalable=0"><link rel="shortcut icon" href="//docs.google.com/favicon.ico"><title>Seite nicht gefunden</title><meta name="referrer" content="origin"><link href="//fonts.googleapis.com/css?family=Product+Sans" rel="stylesheet" type="text/css" nonce="DWyGHSMMe6dSPJKFA1GlKQ"><style nonce="DWyGHSMMe6dSPJKFA1GlKQ">/* Copyright 2022 Google Inc. All Rights Reserved. */
.goog-inline-block{position:relative;display:-moz-inline-box;display:inline-block}* html .goog-inline-block{display:inline}*:first-child+html .goog-inline-block{display:inline}#drive-logo{margin:18px 0;position:absolute;white-space:nowrap}.docs-drivelogo-img{background-image:url('//ssl.gstatic.com/images/branding/googlelogo/1x/googlelogo_color_116x41dp.png');background-size:116px 41px;display:inline-block;he

Image max width should be as text , difference of behaviour : horizontal scrollbar appearing or not

eliselavy commented 2 years ago

Problem with mybinder: ERROR: Could not find a version that satisfies the requirement networkx==2.7.1 (from versions: 0.34, 0.35, 0.35.1, 0.36, 0.37, 0.99, 1.0rc1, 1.0, 1.0.1, 1.1, 1.2rc1, 1.2, 1.3rc1, 1.3, 1.4rc1, 1.4, 1.5rc1, 1.5, 1.6rc1, 1.6, 1.7rc1, 1.7, 1.8rc1, 1.8, 1.8.1, 1.9rc1, 1.9, 1.9.1, 1.10rc2, 1.10, 1.11rc1, 1.11rc2, 1.11, 2.0, 2.1, 2.2rc1, 2.2, 2.3rc3, 2.3rc4, 2.3, 2.4rc1, 2.4rc2, 2.4, 2.5rc1, 2.5, 2.5.1, 2.6rc1, 2.6rc2, 2.6, 2.6.1, 2.6.2, 2.6.3) ERROR: No matching distribution found for networkx==2.7.1

eliselavy commented 2 years ago

ERROR: Could not find a version that satisfies the requirement numpy==1.22.2 (from versions: 1.3.0, 1.4.1, 1.5.0, 1.5.1, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2, 1.9.0, 1.9.1, 1.9.2, 1.9.3, 1.10.0.post2, 1.10.1, 1.10.2, 1.10.4, 1.11.0, 1.11.1, 1.11.2, 1.11.3, 1.12.0, 1.12.1, 1.13.0rc1, 1.13.0rc2, 1.13.0, 1.13.1, 1.13.3, 1.14.0rc1, 1.14.0, 1.14.1, 1.14.2, 1.14.3, 1.14.4, 1.14.5, 1.14.6, 1.15.0rc1, 1.15.0rc2, 1.15.0, 1.15.1, 1.15.2, 1.15.3, 1.15.4, 1.16.0rc1, 1.16.0rc2, 1.16.0, 1.16.1, 1.16.2, 1.16.3, 1.16.4, 1.16.5, 1.16.6, 1.17.0rc1, 1.17.0rc2, 1.17.0, 1.17.1, 1.17.2, 1.17.3, 1.17.4, 1.17.5, 1.18.0rc1, 1.18.0, 1.18.1, 1.18.2, 1.18.3, 1.18.4, 1.18.5, 1.19.0rc1, 1.19.0rc2, 1.19.0, 1.19.1, 1.19.2, 1.19.3, 1.19.4, 1.19.5, 1.20.0rc1, 1.20.0rc2, 1.20.0, 1.20.1, 1.20.2, 1.20.3, 1.21.0rc1, 1.21.0rc2, 1.21.0, 1.21.1, 1.21.2, 1.21.3, 1.21.4, 1.21.5, 1.21.6) ERROR: No matching distribution found for numpy==1.22.2

eliselavy commented 2 years ago

Problem missing library via mybinder: python-louvain==0.16

eliselavy commented 2 years ago

following attribute center=[-80, 70] not supported

eliselavy commented 2 years ago

About version of numpy: pip install --use-deprecated=legacy-resolver numpy==


elisabeth.guerard@MP0351 ~> pip install --use-deprecated=legacy-resolver numpy==                  (base)
ERROR: Could not find a version that satisfies the requirement numpy== (from versions: 1.3.0, 1.4.1, 1.5.0, 1.5.1, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2, 1.9.0, 1.9.1, 1.9.2, 1.9.3, 1.10.0.post2, 1.10.1, 1.10.2, 1.10.4, 1.11.0, 1.11.1, 1.11.2, 1.11.3, 1.12.0, 1.12.1, 1.13.0rc1, 1.13.0rc2, 1.13.0, 1.13.1, 1.13.3, 1.14.0rc1, 1.14.0, 1.14.1, 1.14.2, 1.14.3, 1.14.4, 1.14.5, 1.14.6, 1.15.0rc1, 1.15.0rc2, 1.15.0, 1.15.1, 1.15.2, 1.15.3, 1.15.4, 1.16.0rc1, 1.16.0rc2, 1.16.0, 1.16.1, 1.16.2, 1.16.3, 1.16.4, 1.16.5, 1.16.6, 1.17.0rc1, 1.17.0rc2, 1.17.0, 1.17.1, 1.17.2, 1.17.3, 1.17.4, 1.17.5, 1.18.0rc1, 1.18.0, 1.18.1, 1.18.2, 1.18.3, 1.18.4, 1.18.5, 1.19.0rc1, 1.19.0rc2, 1.19.0, 1.19.1, 1.19.2, 1.19.3, 1.19.4, 1.19.5, 1.20.0rc1, 1.20.0rc2, 1.20.0, 1.20.1, 1.20.2, 1.20.3, 1.21.0rc1, 1.21.0rc2, 1.21.0, 1.21.1, 1.21.2, 1.21.3, 1.21.4, 1.21.5, 1.21.6)
ERROR: No matching distribution found for numpy==

The version of pip can be versioned also:

in requirements.txt example mybinder https://github.com/binder-examples/requirements
in environment.yml example mybinder https://github.com/binder-examples/conda

Screenshot 2022-05-12 at 15 04 31

Maybe force user to define not the last version of a package or now version of python is required: As for numpy 1.22.2 The Python versions supported for this release are 3.8-3.10.

eliselavy commented 2 years ago

same as here https://githubhot.com/repo/vega/vega-lite/issues/8082

eliselavy commented 2 years ago

@inactinique Can be send to the review?

https://journalofdigitalhistory.org/en/notebook-viewer/JTJGcHJveHktZ2l0aHVidXNlcmNvbnRlbnQlMkZqZGgtb2JzZXJ2ZXIlMkZqZGgwMDItVmVhSzU4V0JzODJDJTJGbWFpbiUyRmFydGljbGUtbm90ZWJvb2suaXB5bmI=

But:

still a problem to fix in the mybinder
author needs to fix the references as they appears duplicate - i suppose he had the problem with the cite2c plugin (not being able to see the references in the notebook itself) , that's why he add it manually, example below:

=> do i contact the author in order to fix this or he will do it after the first review ?

inactinique commented 2 years ago

Yes. Let's send it

eliselavy commented 1 year ago

TO REVIEW

eliselavy commented 1 year ago

From mybinder:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
jupyterlab-server 2.15.2 requires jinja2>=3.0.3, but you have jinja2 3.0.0 which is incompatible.

eliselavy commented 1 year ago

Mybinder validated: python-decouple==3.4 jinja2==3.0.3 jsonschema==3.2.0

eliselavy commented 1 year ago

@inactinique Can be send to the REVIEW. Link for the article: https://journalofdigitalhistory.org/en/notebook-viewer/JTJGcHJveHktZ2l0aHVidXNlcmNvbnRlbnQlMkZqZGgtb2JzZXJ2ZXIlMkZqZGgwMDItVmVhSzU4V0JzODJDJTJGbWFpbiUyRmFydGljbGUtbm90ZWJvb2suaXB5bmI=?idx=122 Link for the mybinder: https://mybinder.org/v2/gh/jdh-observer/jdh002-VeaK58WBs82C/HEAD?filepath=article-notebook.ipynb

C2DH / jdh-notebook

Technical review https://github.com/jdh-observer/jdh002-VeaK58WBs82C #64