Closed eliselavy closed 1 year ago
Done.
@eliselavy can you check?
@biumiamy design review not my task - social media needs to be generated
Can I get access rights? I can't upload anything to the repo.. @inactinique or @eliselavy
So is Andy reviewing right now and should I implement the changes then? or is it already finished :)
What happened here with the
So is Andy reviewing right now and should I implement the changes then? or is it already finished :)
I've done it yesterday. ("I" being @inactinique)
What happened here with the (at the top of the table)? Is it correct like this?
I'm not sure I do understand what you mean? Can you precise?
the "chr" should not be there I think?
the "chr" should not be there I think?
OK, sorry did not get that. I'll change that right away. I also gave you access right (and logged out / logged in to get back my proper identity :) )
yes, now it worked :) I added the socialmediacover
the "A data.frame: 18 × 2" is also a bit weird above the table. Is it correct as well?
it seems to be here again in the table above figure 10 ("chr" and "!–/–"):
It's in all tables (data.frame +
But it's generated by the R code based on data files, I suppose. I need to check the files and to see what we can do about it.
okay I see
No idea where it comes from.
except for the table issue, the rest looks fine. I only found one tiny thing, there's a space missing here (between " and ():
corrected
@inactinique Ok Licence CC-BY was already inserted in the notebook - legal document saved in atlas
@biumiamy Integrate last remarks made by the author - after this made inform me in order to regenerate:
I have changed my affiliation since submission, so we have to update that. My current affiliation is "Scuola Normale Superiore, Pisa", the institutional mail address is ettore.costa@sns.it
There are two bigger problems. One is whether to change references to my past work. Whenever the article says "Costa argued" should we change it to "I argued"? We had to anonimyze the article for peer-review, but we could change it for publication. The interested paragraphs are 6, 12, 15, 101, 104.
The second problems is a couple of mistakes in the references, which I had corrected in my last version, but probably there was a misunderstanding. These are the following: Van Kemseke publication date is wrong. It should 2006 There are two separate references to my 2022 article:
Costa, E. (2022). Socialist World from Balancing East and West to Militant Anti-Communism: Reading the Beginning of the Cold War in the Journal of the Socialist International (1947–1949). Journal of Cold War History, 24(1).
Costa, E. (2022). From East-West Balancing to Militant Anti-Communism: The Socialist International and the Beginning of the Cold War, 1947–1949. Journal of Cold War Studies, 24(2), 95–131. https://doi.org/10.1162/jcws_a_01044
Only the second one is correct
Smaller mistakes in the text:
abstract: "what role of European social democracy" to "what role European social democracy" Paragraph 30: "Topic modeling works under the assumption that the order of the words within the document text is irrelevant" cancel "text" Paragraph 57 should be also Narrative, not just hermenutics
@biumiamy not possible the double tag : pending issue https://github.com/C2DH/journal-of-digital-history/issues/323
we have already discussion it should be remove from the guidelines
Okay, its done, except for the email address. where does that go? @eliselavy @inactinique
@eliselavy i go to update the email to the database, or check if there is a mention in the article - affiliation need to be updated
It does not go anywhere, in fact, does it ? For other articles, I don’t remember that we published author’s email address.
From: Mirjam Pfeiffer @.> Date: Monday, 6 March 2023 at 16:27 To: C2DH/jdh-notebook @.> Cc: Frédéric CLAVERT @.>, Mention @.> Subject: Re: [C2DH/jdh-notebook] Integrate copy -editing for the article of Taking the Measure of Social Democracy: Exploring the Ideology of the Socialist International through Topic Modeling (Issue #99)
Okay, its done, except for the email address. where does that go? @eliselavyhttps://github.com/eliselavy @inactiniquehttps://github.com/inactinique
— Reply to this email directly, view it on GitHubhttps://github.com/C2DH/jdh-notebook/issues/99#issuecomment-1456344119, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAHYLLBDSE7IQGJ3QFLCU7TW2X64DANCNFSM6AAAAAAUWMEVOE. You are receiving this because you were mentioned.Message ID: @.***>
@inactinique all corrections are done
Great! Will do the propaganda tomorrow.
https://github.com/jdh-observer/jdh001-MyifnvNPDgUx/blob/main/taking-the-measure-of-social-democracy.ipynb
Costa_LanguageReview AOD 24-01-2023.docx