Open nidico opened 9 years ago
I had this in mind when I implemented the functions for adding/updating keys. It would be possible, to add a user list view for admins, which links to edit actions using a quite similar form als already present on the /pgp view. The user id is just a variable in a hidden field in the templates (only admins may change all ids). For admins it would be possible to change keys of other users even now, if they would change the form data on /pgp. I don't know, when I will get to that interface, but not very soon.
I agree, your routing suggestions would be intuitive, but I had no time yet to check, how to hook whole forms into the user menue or the administration area.
There also needs to be a place for the public PGP key of the server accessible to the users. It would be too much to add those 6 boxes to /my/account for that. That would need e.g. a download instead of a textbox for the key itself, which is another thing I had no time to check, how this is done in ruby/rails/redmine.
Adding the public PGP key on the user's profile would also have the advantage, that users could access each others key and maybe administrators could change users pgp keys just by editing their profile without the need of another interface. Probably depends on the possiblity to access variables of the calling context from within the embedded content.
I also agree, that the link is too prominent now, but there are no good alternatives in the redmine menue system. Near 'my/account' seemed to be most reasonable.
If I find out, how to use those hooks for this need and how to provide a download (or someone points me to some useful examples), I will change the routing / menu and in the best case it would fix the need for an administrator edit interface.
I would respectfully disagree that the top-level /pgp menu item is too prominent, but perhaps this could be configurable. I think Redmine is commonly understood to be an e-mail heavy system, and adding PGP to it is a significant modification that should be clearly evident and it should be easy for users to find where to upload their keys.
+1 I agree admins should be able to set user PGP public keys through an interface. Otherwise, if you're trying to pre-populate keys for a set of new users, you need to login in as each and every one, which is laborious.
Maybe #13 could be easily used to auto-fetch keys from a server....
In order to increase use of this awesome plugin, it'd be great if administrators could set the public keys of other users.
Routing-wise, I'd suggest
This would also allow to get away with the top-level PGP menu item, which is placed too prominently anyway (you only need it once) and might confuse users.