CCBR / spacesavers2

https://ccbr.github.io/spacesavers2
0 stars 1 forks source link

Issue70 #74

Closed kopardev closed 7 months ago

kopardev commented 8 months ago

Changes

kelly-sovacool commented 7 months ago

Currently, the output files from catalog, grubbers, and mimeo all start with a common prefix to encode the date, input directory, and user. However, the blame matrix is always called blamematrix.tsv -- should this file instead be renamed to include the same common prefix as the other files?

kelly-sovacool commented 7 months ago

I fixed an issue in the e2e docs (bdee6d3) and also made minor updates to the changelog notes -- e.g. succinctly describing issue 71 so readers can get the gist of the fix without going to that issue.

kopardev commented 7 months ago

I wonder if e2e should have also have a limit argument to pass on to grubbers with the same default value?

It does

kopardev commented 7 months ago

I fixed an issue in the e2e docs (bdee6d3) and also made minor updates to the changelog notes -- e.g. succinctly describing issue 71 so readers can get the gist of the fix without going to that issue.

Further updated docs (f72923a)

kopardev commented 7 months ago

Currently, the output files from catalog, grubbers, and mimeo all start with a common prefix to encode the date, input directory, and user. However, the blame matrix is always called blamematrix.tsv -- should this file instead be renamed to include the same common prefix as the other files?

Done in 615f1ca .

kopardev commented 7 months ago

Also, fixes #64