CCI-MOC / process_csv_report

Some scripts to help process our billing reports
0 stars 3 forks source link

Invoice classes should not modify or reassign `self.data` #111

Open QuanMPhm opened 2 weeks ago

QuanMPhm commented 2 weeks ago

Currently, all Invoice subclasses reassign self.data before exporting their internal dataframes. This reassignment is done mostly because each invoice only needs to export certain columns. While this step does not change the internal dataframe's data, and has no unwanted side effects, it's presence still raises unwanted ambiguity, and goes against our belief that the Invoice subclasses should not modify their given dataframes.