CCI-MOC / process_csv_report

Some scripts to help process our billing reports
0 stars 3 forks source link

Update billing flowchart #81

Open QuanMPhm opened 4 weeks ago

QuanMPhm commented 4 weeks ago

As part of implementing prepaid group billing, we want to update the billing flowchart.

@joachimweyl This is currently blocked until we know whether the BU subsidy is applied before or after the Prepayment credit. From the comments I see in the Scaffolding document, this seems to be more complicated than it seem?

joachimweyl commented 3 weeks ago

Please see the update in the Prepaid document. The plan is to do the calculation before but not show it to the MGHPCC CSV. We use $100 less of the Prepaid credit and send it to MGHPCC they send back the bill of $100 and the Subsidy pays it.

QuanMPhm commented 3 weeks ago

@joachimweyl @naved001 @knikolla Here is the updated flowchart, which includes clarifications about the ordering of the different credits. I'll make a PR for it once I actually finish implementing the Prepayment feature. invoice_flowchart_2

joachimweyl commented 3 weeks ago

Looks good, only change I can see is that "alias file" might not provide enough information about what you are referring to. Can you add links to the image in other words could alias be a link to the file same with nonbilled PIs etc?

QuanMPhm commented 3 weeks ago

@joachimweyl From what I could see, there is no way to add hyperlinks to an image in a Github page. The image file format that could contain hyperlinks (SVG) doesn't seem to work as expected. I will test this more when I update the README and submit the PR for this.

In any case, most of the files referenced in this image is private, including the alias file. The only thing public is the institute.json file.

joachimweyl commented 3 weeks ago

Thanks for checking. Can you just add a little more detail to the alias file bubble so it is clear what it is an alias for?