search

CCr4ft3r / DimensionalThreading-Reforged

Unofficial Forge port of Dimensional Threading
GNU Lesser General Public License v3.0
2 stars 2 forks source link

Dimensional-Threading-Reforged-1.18.2-1.2.7 breaks multiblocks #1

Closed border999 closed 1 year ago

border999 commented 1 year ago

So far I have noticed that this version breaks AE2's cabling and Bigger Reactor's reactor multiblocks.

CCr4ft3r commented 1 year ago

This is a design issue of AE2 since it isn't thread-safe. They don't seem interested in fixing it https://github.com/AppliedEnergistics/Applied-Energistics-2/issues/6261 https://github.com/WearBlackAllDay/DimensionalThreading/issues/60

Sorry but thread-safety must be ensured by the mods.

border999 commented 1 year ago

what about Bigger Reactors?

CCr4ft3r commented 1 year ago

Probably it's the same. If you want you can add your crash-report or latest.log via https://gist.github.com/ to this issue. I can then check if the issue can be fixed by DimThread (even though it is very unlikely)

border999 commented 1 year ago

no actual crash and the log doesn't show anything as far as I can tell.

border999 commented 1 year ago

I might recommend just loading up your mod and add in bigger reactors

Kasualix commented 1 year ago

Trillions of modders don't write codes with thread-safety. Fact. It's just... quite unlikely, in trillions of aspects.

CCr4ft3r commented 1 year ago

After adding the mod I couldn't found "reactor multiblocks".

Please provide the following informations: -describe the unexpected behaviour -describe the expected behaviour -steps to reproduce it (for example building something specific)

border999 commented 1 year ago

bigger reactors uses a combination of Reactor Casings, reactor glass, control rods, power taps, fuel input blocks, and a reactor terminal to, in a cuboidal configuration, create a multiblock reactor. The simplest reactor I can think to do is a literal 3x3x3 with one control rod on top, a terminal on one face, a power tap on another, followed by at least one fuel input block and every other block being reactor casing surround the one fuel rod.

border999 commented 1 year ago

with all of that being said. The multiblock that is supposed to form from these blocks being placed together in a valid manner does not occur with your mod installed.

CCr4ft3r commented 1 year ago

Sorry but I really have no idea about this. Since there is no exception, crash or log output it's probably related to Better Reactors internals.