search

CFLombardi / sethBot

The bot for the Good Job! discord server
MIT License
3 stars 0 forks source link

For resolution to issue 21 #29

Closed CFLombardi closed 5 years ago

CFLombardi commented 5 years ago

I noticed that this https://github.com/CFLombardi/sethBot/issues/21 was still open. I believe the update here should resolve the issue.

Kydane commented 5 years ago

This doesn't solve the issue at hand. I'll try and break it down a little further.

In seth.js, we read in everything from the config.json including the marking we use for the prefix that signifies the start of a command. (in our case its a an exclamation point)

The behavior we would want is that all a user should have to do is change the '!' to any other special character under the sun and all the commands would work with that new character. So instead of !dosh if a user wanted to use ~dosh, it could easily be done by changing one property and being on our way. Instead, inside dosh.js, we are hardcoding a "!dosh" for the split meaning that it will only ever work with that prefix. In order to fix that, we should use the same exact prefix defined in the config.json to do the split. (So splitting on something like config.prefix+"dosh" )

Kydane commented 5 years ago

@CFLombardi I added changes to account for twitch. When you're ready, you can approve and merge