search

CMPUT404 / socialdistribution

A distributed social network
http://socshizzle.divshot.io
Apache License 2.0
0 stars 2 forks source link

Breaking bugs and tests #201

Closed xkb closed 9 years ago

xkb commented 9 years ago

I'm assuming the rest of integration test failures are still normal?

The hyphenation in CachedAuthor renders the front end completely unusable. Various methods are sending different formats of the same id.

I understand that we need it to get other teams crap working but there must be a better solution.

  1. It's broke.
  2. If we integrate with another team that doesn't hyphenate.

Possible Solution: Change the id field in CachedAuthor to a CharField. CachedAuthor instances are only created from existing authors or foreign authors. We don't need auto generation or UUIDField formatting.

This would also enable us to integrate with other teams that don't use uuids and as long their ids are unique.

jcairo commented 9 years ago

Too many dd's. I added the author URL back in PR 203.

derekdowling commented 9 years ago

@KarimBaaba the integration tests only work if we're running their server locally. There are too many conditions that they impose to test against their production server. I think changing the CachedAuthor to a charfield is the best bet.

derekdowling commented 9 years ago

This has been since dealt with, thanks for hunting this down @KarimBaaba.