Fix crash when --suppress_output_file_sequence is set

CTHRU / Hitrava

Convert your Huawei Health sport activities and import them in Strava.

Other

352 stars 34 forks source link

Fix crash when --suppress_output_file_sequence is set #19

Closed starkmapper closed 4 years ago

starkmapper commented 4 years ago

Ensure output_file_suffix is defined, even if --suppress_output_file_sequence is set.

Thanks for this tool :-).

Any chance you're considering publishing it to pypi?

Cheers,

Mark

CTHRU commented 4 years ago

@starkmapper Thank you for finding and resolving the bug. I just wanted to let you know that I will not merge your pull request for the reasons explained in the contributing guidelines. Thank you for your understanding.

I will also solve the issue a bit different because I noticed a code duplication.

I didn't look into publishing on pypi (yet) and frankly I didn't know about it. I will add your suggestion as a potential enhancement.

starkmapper commented 4 years ago

No problem, just happy to help! The tool works great so far, so no need to buy a new watch just yet :-)

Thanks again!