Still WIP, created first pass at the ADS1115 sensor reading and press…

CU-SRL / DAQ

Code for Static Test Stand DAQ

2 stars 0 forks source link

Still WIP, created first pass at the ADS1115 sensor reading and press… #24

Closed EpicIan60142 closed 3 years ago

EpicIan60142 commented 3 years ago

…ure conversions

cartermak commented 3 years ago

Nice! I look forward to seeing this come together and operate with hardware.

Hardcoding is fine for now, but in the future, we should replace these hardcoded variables (ads0, ads1, ...) with lists of objects that are created dynamically according to the configuration file, and all those if statements could be replaced with a for-loop. Otherwise, the purpose of the JSON is kinda null.

cartermak commented 3 years ago

I also would like to see this modularized into a class (see Hypervisor.py or the talk/listen threads for examples), but that doesn't need to happen right away.