search

CUAHSI / HydroClient

Generally available source code for the CUAHSI HydroClient Web Application
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

Incorrect Value Count #31

Open Lizabrazil opened 6 years ago

Lizabrazil commented 6 years ago

Search for Shale Hills CZO data 2012-present. Order the results by Value Count, see there are time series with ~9 million data values. This is incorrect, it is miscalculating by not taking date range into account and calculating all values for that entire time series. This prevents the user from downloading.

Lizabrazil commented 6 years ago

The true issue is that for some data types with unknown value, the value count does not accurately count. The solution should be that all data types=unknown, value count=unknown

Lizabrazil commented 6 years ago

Another issue related to this, there are data types that pop up as unknown and were harvested incorrectly.

martinseul commented 6 years ago

we do estimate the values in the “UpdateDataCartToDateInterval “ method if the flag IsRegular is set in the variable table. there was a bug in the code to not correctly calculate the ratio of the entire series to the currently search time period thus always assuming the entire record was within the current shorter time period this fix adresses commit 1c3fcb5e52f7e08b09940d09652107a2650ab151 here https://github.com/CUAHSI/Azure-Hydroservertools/commits/master # deployed as version 2.0.5 here prod-hydroclient-stage-hydroclient.azurewebsites.net. To test:

  1. select shalehills czo dataservice, stay at zoom level
  2. search and click marker check order by datavalue desc
  3. check for datavlues there should be a large one with >9mil rec 4 change search to start 10/23/2012 this select a subset and the value should be a percentage of the total value. This is an estimated value assuming a regular distribution
martinseul commented 6 years ago

did not mean to close