CUB-Libraries-CTA / counter-data-loader

Loads COUNTER database from JR1 report spreadsheets
1 stars 2 forks source link

Support TRJ1, TRB1 Type Spreadsheets in 2022 Data Load (3) #73

Closed ericnienhouse closed 1 year ago

ericnienhouse commented 1 year ago

Estimate: 3

In COUNTER 2022 data there are some TR-J1, TR-B1 These types are not currently loaded, and should be.

These may need a slight change (no access type column if found in sheet, instead found in header, assume “controlled” is access type)

Acceptance Criteria:

Support pre-processing and loading TR-J1, TR-B1 spreadsheet types. Set access type appropriately. Test on several spreadsheet examples.

Note: this may require refactoring to add this new report processing behavior.

ericnienhouse commented 1 year ago

Note deprecated code may support this. This is not needed for the 2021 data, however, it is for the 2022. This change may affect the pre-processor, to allow TRJ1, TRB1, access type is not required (other types, access type is required)

This is not required for the current release, we'll add to next release.

bonnland commented 1 year ago

The latest commit on the "develop" branch fixes this issue.

Note that Excel files in .XLS format are not supported; they must be saved as .XLSX files before being processed.