search

CampbellGroup / common

Shared campbell lab code.
GNU Lesser General Public License v3.0
8 stars 5 forks source link

added a method to wavemeterclient such that it checks the config file… #104

Closed gregllong closed 8 years ago

gregllong commented 8 years ago

… for if the client should be maximized upon startup.

Signed-off-by: Xueping Long gregllong@gmail.com

The fixed minimum size for the wavemeter client becomes a problem when the client is opened with a netbook. I did a quick and dirty fix to this problem. It does not look too great but I'm able to see all channels on the netbook now.

Please review: @jayich @aransfor @theoriginaljuice

jayich commented 8 years ago

LGTM

aransfor commented 8 years ago

@gregllong Nice didnt know about qwidget.showMaximized! I think instead of adding another item to the config we could just have this be conditional for all small screens. Using the following logic we should be able to avoid adding to the configs and be able to see it on all small screens (Im thinking Pi's of course)

desktop = QtGui.QDesktopWidget() screensize = desktop.availableGeometry() if (screensize[0] or screensize[1]) <= 1080: self.showMaximized

gregllong commented 8 years ago

@jayich @aransfor @theoriginaljuice

I changed the code a little bit. There's a lower limit on the screen size now such that if the limit is not met, the client window just gets maximized.

jayich commented 8 years ago

LGTM.

jayich commented 8 years ago

LGTM.

aransfor commented 8 years ago

LGTM, nice fix!

gregllong commented 8 years ago

@theoriginaljuice when you have time, please take a look

jchristensen133 commented 8 years ago

LGTM