CampbellGroup / common

Shared campbell lab code.
GNU Lesser General Public License v3.0
8 stars 5 forks source link

Labrad client now passes environment password to wavemeter computer #112

Closed aransfor closed 8 years ago

aransfor commented 8 years ago

This should make us compatible with new and old labrad

aransfor commented 8 years ago

@ypark137 You should checkout this branch on you wavemeter client computer and see if it works and if the password issue is gone

jayich commented 8 years ago

Nice work, LGTM. Dig the style upgrades.

gregllong commented 8 years ago

LGTM.

Faster than @michaelip9228 this time.

aransfor commented 8 years ago

@gregllong you got :8ball: :8ball: ?

gregllong commented 8 years ago

Maybe we should merge this PR first, and branch the latest commits to another branch, something like "amr/new_node"?

jayich commented 8 years ago

Sounds good to me. New content.

jayich commented 8 years ago

client looks fine. LGTM.

aransfor commented 8 years ago

@gregllong its all related to the upgrade and the node is independant of everything... I can move it but I dont think its super necessary

gregllong commented 8 years ago

LGTM

jayich commented 8 years ago

@aransfor , please merge when you have a chance if you are happy with the changes.