search

CampbellGroup / common

Shared campbell lab code.
GNU Lesser General Public License v3.0
8 stars 5 forks source link

Amr/wavemeter rear port #130

Closed aransfor closed 8 years ago

aransfor commented 8 years ago

Sorry about the default user. I will update the computer. @gregllong @theoriginaljuice @jayich I have done two things with this pull request, I added a minor function to the wavemeter server and I have mimicked the martinis serial server for the evPump. The advantages of this format is multiple devices can be immediately used. Also serial server, device server and the client will run independent of each other so startup order does not matter.

aransfor commented 8 years ago

@gregllong the path to the connected ports is registry/Servers/evPump/Links

the key value pair looks like this: ("qsimexpcontrol Serial Server", "/dev/ttyUSB0")

gregllong commented 8 years ago

The evpump now works for the molecule experiment. LGTM

gregllong commented 8 years ago

BTW how do you approve a PR? I want that!

jchristensen133 commented 8 years ago

LGTM

aransfor commented 8 years ago

@jayich @gregllong @theoriginaljuice

This pull request has been a pain and deviated from its original intent... Just look over these files that fix serial connection issues and I will merge and use git in a more responsible way in the future.... thanks in advance

aransfor commented 8 years ago

also @jayich I think all of your comments were true, however to avoid similar conflicts in the future I would really like to have the same EXACT convention as the martinis group

jayich commented 8 years ago

LGTM.

aransfor commented 8 years ago

@theoriginaljuice waiting on you

jchristensen133 commented 8 years ago

@aransfor LGTM.