search

CampbellGroup / common

Shared campbell lab code.
GNU Lesser General Public License v3.0
8 stars 5 forks source link

Amr/bristol #134

Closed aransfor closed 7 years ago

aransfor commented 7 years ago

Added bristol server/client for shared bristol wavemeter

aransfor commented 7 years ago

@theoriginaljuice @gkchen @gregllong note that this pull request will also merge the JC/iXon since i pulled it into this branch to use the camera.

aransfor commented 7 years ago

@jayich the camera code is straight copy and pasted if someone wants to re-write the config and test it more power to them

gregllong commented 7 years ago

it probably makes more sense to fork the andor camera code to a repo in CampbellGroup than put it in common...

aransfor commented 7 years ago

@gregllong just to go online with our earlier discussion this code is a subfolder on the haeffner code and has since been modified making forking difficult

aransfor commented 7 years ago

@gregllong I can move that file. I dont know if we have a folder that already is for general stuff but we can make one. perhaps a utility folder? or I can just shove it in qtui...

jchristensen133 commented 7 years ago

@aransfor LGTM

gkchen commented 7 years ago

LGTM

On Thu, Dec 8, 2016, 2:48 PM Justin notifications@github.com wrote:

@aransfor https://github.com/aransfor LGTM

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/CampbellGroup/common/pull/134#issuecomment-265879214, or mute the thread https://github.com/notifications/unsubscribe-auth/AHuAOuMIOrerkewtTL1wSvrIpSfCdLM_ks5rGIlIgaJpZM4LIDtF .

--

Regards,

Gary Chen

michaelip9228 commented 7 years ago

LGTM

gregllong commented 7 years ago

LGTM

jayich commented 7 years ago

LGTM, let's get that config convention fixed ASAP.