search

CampbellGroup / common

Shared campbell lab code.
GNU Lesser General Public License v3.0
8 stars 5 forks source link

protect master #186

Closed jayich closed 7 years ago

jayich commented 7 years ago

We should make master a protected branch that requires at least an approved code review before changes can be merged in.

jayich commented 7 years ago

@aransfor thoughts here? Basically with GitHub settings we can permit code to be merged into master only if it has been reviewed (those with ownership permissions can still merge). If you give this a thumbs up I'll make the change.

aransfor commented 7 years ago

LGTM

jayich commented 7 years ago

@aransfor , I enabled the most basic master review protection. Someone needs to approve the code before it can be merged. There are finer-grained settings that we could consider but this will likely be good for the foreseeable future.